From: Eric Blake <eblake@redhat.com>
To: Romain Dolbeau <romain@dolbeau.org>, qemu-devel@nongnu.org
Cc: Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2 V4] spaces around '<<' everywhere
Date: Fri, 07 Mar 2014 06:33:43 -0700 [thread overview]
Message-ID: <5319CAB7.3080805@redhat.com> (raw)
In-Reply-To: <1394198414-22504-3-git-send-email-romain@dolbeau.org>
[-- Attachment #1: Type: text/plain, Size: 865 bytes --]
On 03/07/2014 06:20 AM, Romain Dolbeau wrote:
> Signed-off-by: Romain Dolbeau <romain@dolbeau.org>
> ---
> hw/net/e1000.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
> if (++s->eecd_state.bitnum_in == 9 && !s->eecd_state.reading) {
> - s->eecd_state.bitnum_out = ((s->eecd_state.val_in & 0x3f)<<4)-1;
> + s->eecd_state.bitnum_out = ((s->eecd_state.val_in & 0x3f) << 4)-1;
If you're fixing operator spacing, why not also fix the spacing around
binary '-' at the same time?
> for (i = 0; i < 3; i++) {
> - d->eeprom_data[i] = (macaddr[2*i+1]<<8) | macaddr[2*i];
> + d->eeprom_data[i] = (macaddr[2*i+1] << 8) | macaddr[2*i];
Likewise around * and +
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-03-07 13:33 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 9:08 [Qemu-devel] [PATCH v2 1/1] e1000: add the ability to select among several specific types of e1000[e]; 82566DM emulation ; some pointers to documentations and details Romain Dolbeau
2014-03-05 14:14 ` [Qemu-devel] [PATCH v3] " Romain Dolbeau
2014-03-05 16:55 ` Andreas Färber
2014-03-06 9:01 ` Romain Dolbeau
2014-03-07 13:20 ` [Qemu-devel] [PATCH 0/2 V4] E1000 device selection & 82566DM support Romain Dolbeau
2014-03-07 13:20 ` [Qemu-devel] [PATCH 1/2 V4] e1000: add the ability to select among several specific types of e1000[e]; 82566DM emulation ; some pointers to documentations and details Romain Dolbeau
2014-03-10 12:56 ` Stefan Hajnoczi
2014-03-07 13:20 ` [Qemu-devel] [PATCH 2/2 V4] spaces around '<<' everywhere Romain Dolbeau
2014-03-07 13:33 ` Eric Blake [this message]
2014-03-10 12:57 ` [Qemu-devel] [PATCH 0/2 V4] E1000 device selection & 82566DM support Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5319CAB7.3080805@redhat.com \
--to=eblake@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=romain@dolbeau.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).