From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51917) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLwpf-0002TI-6K for qemu-devel@nongnu.org; Fri, 07 Mar 2014 10:37:11 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLwpa-000419-N4 for qemu-devel@nongnu.org; Fri, 07 Mar 2014 10:37:07 -0500 Received: from mx1.redhat.com ([209.132.183.28]:12690) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLwpa-000414-FC for qemu-devel@nongnu.org; Fri, 07 Mar 2014 10:37:02 -0500 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s27Fb1IJ006107 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 7 Mar 2014 10:37:01 -0500 Message-ID: <5319E79C.7030505@redhat.com> Date: Fri, 07 Mar 2014 08:37:00 -0700 From: Eric Blake MIME-Version: 1.0 References: <20140307004004.GA6114@amt.cnet> <53194936.9000606@redhat.com> <20140307151333.GA26026@amt.cnet> In-Reply-To: <20140307151333.GA26026@amt.cnet> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tHfFbC9d7jCnrsgP3OoFAmGpsgbPCQ6tm" Subject: Re: [Qemu-devel] [PATCH] mempath: add option to specify minimum huge page size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcelo Tosatti Cc: Paolo Bonzini , qemu-devel , Igor Mammedov This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --tHfFbC9d7jCnrsgP3OoFAmGpsgbPCQ6tm Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/07/2014 08:13 AM, Marcelo Tosatti wrote: > On Thu, Mar 06, 2014 at 09:21:10PM -0700, Eric Blake wrote: >> On 03/06/2014 05:40 PM, Marcelo Tosatti wrote: >>> >>> Failing initialization in case hugepage path has=20 >>> hugepage smaller than specified. >>> >>> Signed-off-by: Marcelo Tosatti >>> >>> diff --git a/exec.c b/exec.c >>> index b69fd29..c95a0f3 100644 >>> --- a/exec.c >>> +++ b/exec.c >> >>> }; >>> =20 >>> +static QemuOptsList qemu_mempath_opts =3D { >>> + .name =3D "mem-path", >> >>> - case QEMU_OPTION_mempath: >>> - mem_path =3D optarg; >>> + case QEMU_OPTION_mempath: { >>> + opts =3D qemu_opts_parse(qemu_find_opts("mem-path"),= optarg, 1); >> >> Pre-existing, but this is yet another inconsistent naming between C >> objects and the command line. If we were consistent, it should be nam= ed >> QEMU_OPTION_mem_path, and qemu_mem_path_options. (See my recent >> complaint about other misnamed options: >> https://lists.gnu.org/archive/html/qemu-devel/2014-03/msg01131.html) >=20 > Hi Erik, It's Eric, but you're not the first to be affected by finger memory :) >=20 > What is the practical effect of the mismatch? Harder to grep for things like 'mem.path' (to see both -mem-path strings and mem_path variable names) when looking for all places in the code base related to a given command line or QMP spelling. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --tHfFbC9d7jCnrsgP3OoFAmGpsgbPCQ6tm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTGeecAAoJEKeha0olJ0NqwuAH/A0vLOQfqIPzmuaZocLvmJaS qeME7CXY3kBqwqMIUAkKoMRa+aa+4j4QYM8dV+exzJqTvVhRGSufetS/73rOC7b5 DWmZTi5WyT+7mXCe3nuP/96BmU3ZlO5yZAFaGfCWFrl/o/FzxEzskLr8FVIdba3Z IeevkAidICacah5JL/FpNh80fuhRXYUztum+lVDwOIwVy5XSXaf/cM0FRvM8blVX RyVqBntIIWPj2jdvPZ3cAM/bXKPmZF9VZd5mgor3ROxHLuIe2oXtST7BCC8dL1SM zVxPnC73qvxd02pkADSLGeax+H/LKtWx5ZHQvtJIrZ14yVajOj65oaJBJp/moDs= =YHjh -----END PGP SIGNATURE----- --tHfFbC9d7jCnrsgP3OoFAmGpsgbPCQ6tm--