From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33701) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLxca-0004Dt-Ov for qemu-devel@nongnu.org; Fri, 07 Mar 2014 11:27:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WLxcU-0003hd-Pa for qemu-devel@nongnu.org; Fri, 07 Mar 2014 11:27:40 -0500 Received: from mx1.redhat.com ([209.132.183.28]:46258) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WLxcU-0003hW-H2 for qemu-devel@nongnu.org; Fri, 07 Mar 2014 11:27:34 -0500 Message-ID: <5319F36E.2040603@redhat.com> Date: Fri, 07 Mar 2014 17:27:26 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1394040647-20083-1-git-send-email-marcel.a@redhat.com> <1394040647-20083-4-git-send-email-marcel.a@redhat.com> <5319087A.3090403@suse.de> <1394170376.2663.24.camel@localhost.localdomain> <5319AD0C.9060800@suse.de> <1394209338.2663.51.camel@localhost.localdomain> In-Reply-To: <1394209338.2663.51.camel@localhost.localdomain> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 3/3] hw/boards: converted current_machine to be an instance of MachineCLass List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Cc: qemu-devel@nongnu.org, ehabkost@redhat.com, mst@redhat.com, Alexey Kardashevskiy , armbru@redhat.com, lcapitulino@redhat.com, blauwirbel@gmail.com, aliguori@amazon.com, imammedo@redhat.com Il 07/03/2014 17:22, Marcel Apfelbaum ha scritto: > There is a problem with it: 'make check fails' on test-qdev-global-props. > - 'qdev_get_machine()' is called by 'device_set_realized()' because static_prop_type > has TYPE_DEVICE as parent. > - The machine is added to the QOM tree *only in vl's main* and this test does not > reach it, but assumes that always will be a machine in the QOM tree. > This is no longer true. > > Possible solution would be making existing 'null machine' a subclass of MachineClass > and add it manually to QOM on this test(and other places as necessary). The risk here is > that there are other places where the machine needs to be added manually to the QOM tree. > (I am trying this option, but make check gets stuck !!!, debugging) This is probably the right thing to do, but I guess it means it's better to leave this series to 2.1. Paolo