From: Don Slutz <dslutz@verizon.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org,
Gerd Hoffmann <kraxel@redhat.com>
Subject: Re: [Qemu-devel] [PATCH buildfix] xenfb: Fix graphic_console_init() build failure
Date: Fri, 07 Mar 2014 17:36:44 -0500 [thread overview]
Message-ID: <531A49FC.10501@terremark.com> (raw)
In-Reply-To: <1394228528-31625-1-git-send-email-afaerber@suse.de>
I just found the same thing:
http://lists.xen.org/archives/html/xen-devel/2014-03/msg00678.html
So you can add my:
Reviewed-by: Don Slutz <dslutz@verizon.com>
-Don Slutz
On 03/07/14 16:42, Andreas Färber wrote:
> In commit 5643706a095044d75df1c0588aac553a595b972b (console: add head
> to index to qemu consoles.) graphic_console_init() was extended to take
> an additional argument, but xenfb was not updated accordingly. Fix it.
>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> hw/display/xenfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c
> index cb9d456..032eb7a 100644
> --- a/hw/display/xenfb.c
> +++ b/hw/display/xenfb.c
> @@ -992,7 +992,7 @@ wait_more:
>
> /* vfb */
> fb = container_of(xfb, struct XenFB, c.xendev);
> - fb->c.con = graphic_console_init(NULL, &xenfb_ops, fb);
> + fb->c.con = graphic_console_init(NULL, 0, &xenfb_ops, fb);
> fb->have_console = 1;
>
> /* vkbd */
next prev parent reply other threads:[~2014-03-07 22:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 21:42 [Qemu-devel] [PATCH buildfix] xenfb: Fix graphic_console_init() build failure Andreas Färber
2014-03-07 22:36 ` Don Slutz [this message]
2014-03-08 6:47 ` Stefan Weil
2014-03-08 12:09 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531A49FC.10501@terremark.com \
--to=dslutz@verizon.com \
--cc=afaerber@suse.de \
--cc=kraxel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).