From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:53635)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1WM3Ns-0007PX-2C
	for qemu-devel@nongnu.org; Fri, 07 Mar 2014 17:36:57 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1WM3Nm-0003l0-Hd
	for qemu-devel@nongnu.org; Fri, 07 Mar 2014 17:36:51 -0500
Received: from fldsmtpe04.verizon.com ([140.108.26.143]:55171)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <dslutz@verizon.com>) id 1WM3Nm-0003ks-E0
	for qemu-devel@nongnu.org; Fri, 07 Mar 2014 17:36:46 -0500
From: Don Slutz <dslutz@verizon.com>
Message-ID: <531A49FC.10501@terremark.com>
Date: Fri, 07 Mar 2014 17:36:44 -0500
MIME-Version: 1.0
References: <1394228528-31625-1-git-send-email-afaerber@suse.de>
In-Reply-To: <1394228528-31625-1-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH buildfix] xenfb: Fix graphic_console_init()
 build failure
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>

I just found the same thing:

http://lists.xen.org/archives/html/xen-devel/2014-03/msg00678.html

So you can add my:

Reviewed-by: Don Slutz <dslutz@verizon.com>

     -Don Slutz

On 03/07/14 16:42, Andreas Färber wrote:
> In commit 5643706a095044d75df1c0588aac553a595b972b (console: add head
> to index to qemu consoles.) graphic_console_init() was extended to take
> an additional argument, but xenfb was not updated accordingly. Fix it.
>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>   hw/display/xenfb.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c
> index cb9d456..032eb7a 100644
> --- a/hw/display/xenfb.c
> +++ b/hw/display/xenfb.c
> @@ -992,7 +992,7 @@ wait_more:
>   
>       /* vfb */
>       fb = container_of(xfb, struct XenFB, c.xendev);
> -    fb->c.con = graphic_console_init(NULL, &xenfb_ops, fb);
> +    fb->c.con = graphic_console_init(NULL, 0, &xenfb_ops, fb);
>       fb->have_console = 1;
>   
>       /* vkbd */