* [Qemu-devel] [PATCH buildfix] xenfb: Fix graphic_console_init() build failure
@ 2014-03-07 21:42 Andreas Färber
2014-03-07 22:36 ` Don Slutz
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Andreas Färber @ 2014-03-07 21:42 UTC (permalink / raw)
To: qemu-devel; +Cc: peter.maydell, Andreas Färber, Gerd Hoffmann
In commit 5643706a095044d75df1c0588aac553a595b972b (console: add head
to index to qemu consoles.) graphic_console_init() was extended to take
an additional argument, but xenfb was not updated accordingly. Fix it.
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
hw/display/xenfb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c
index cb9d456..032eb7a 100644
--- a/hw/display/xenfb.c
+++ b/hw/display/xenfb.c
@@ -992,7 +992,7 @@ wait_more:
/* vfb */
fb = container_of(xfb, struct XenFB, c.xendev);
- fb->c.con = graphic_console_init(NULL, &xenfb_ops, fb);
+ fb->c.con = graphic_console_init(NULL, 0, &xenfb_ops, fb);
fb->have_console = 1;
/* vkbd */
--
1.8.4.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH buildfix] xenfb: Fix graphic_console_init() build failure
2014-03-07 21:42 [Qemu-devel] [PATCH buildfix] xenfb: Fix graphic_console_init() build failure Andreas Färber
@ 2014-03-07 22:36 ` Don Slutz
2014-03-08 6:47 ` Stefan Weil
2014-03-08 12:09 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Don Slutz @ 2014-03-07 22:36 UTC (permalink / raw)
To: Andreas Färber; +Cc: peter.maydell, qemu-devel, Gerd Hoffmann
I just found the same thing:
http://lists.xen.org/archives/html/xen-devel/2014-03/msg00678.html
So you can add my:
Reviewed-by: Don Slutz <dslutz@verizon.com>
-Don Slutz
On 03/07/14 16:42, Andreas Färber wrote:
> In commit 5643706a095044d75df1c0588aac553a595b972b (console: add head
> to index to qemu consoles.) graphic_console_init() was extended to take
> an additional argument, but xenfb was not updated accordingly. Fix it.
>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> hw/display/xenfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c
> index cb9d456..032eb7a 100644
> --- a/hw/display/xenfb.c
> +++ b/hw/display/xenfb.c
> @@ -992,7 +992,7 @@ wait_more:
>
> /* vfb */
> fb = container_of(xfb, struct XenFB, c.xendev);
> - fb->c.con = graphic_console_init(NULL, &xenfb_ops, fb);
> + fb->c.con = graphic_console_init(NULL, 0, &xenfb_ops, fb);
> fb->have_console = 1;
>
> /* vkbd */
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH buildfix] xenfb: Fix graphic_console_init() build failure
2014-03-07 21:42 [Qemu-devel] [PATCH buildfix] xenfb: Fix graphic_console_init() build failure Andreas Färber
2014-03-07 22:36 ` Don Slutz
@ 2014-03-08 6:47 ` Stefan Weil
2014-03-08 12:09 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Stefan Weil @ 2014-03-08 6:47 UTC (permalink / raw)
To: Andreas Färber, qemu-devel; +Cc: peter.maydell, Gerd Hoffmann
Am 07.03.2014 22:42, schrieb Andreas Färber:
> In commit 5643706a095044d75df1c0588aac553a595b972b (console: add head
> to index to qemu consoles.) graphic_console_init() was extended to take
> an additional argument, but xenfb was not updated accordingly. Fix it.
>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
> hw/display/xenfb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c
> index cb9d456..032eb7a 100644
> --- a/hw/display/xenfb.c
> +++ b/hw/display/xenfb.c
> @@ -992,7 +992,7 @@ wait_more:
>
> /* vfb */
> fb = container_of(xfb, struct XenFB, c.xendev);
> - fb->c.con = graphic_console_init(NULL, &xenfb_ops, fb);
> + fb->c.con = graphic_console_init(NULL, 0, &xenfb_ops, fb);
> fb->have_console = 1;
>
> /* vkbd */
>
Same problem here. There is also a 2nd call of that function in the same
file, but it is currently disabled by #if 0...#endif.
Reviewed-by: Stefan Weil <sw@weilnetz.de>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH buildfix] xenfb: Fix graphic_console_init() build failure
2014-03-07 21:42 [Qemu-devel] [PATCH buildfix] xenfb: Fix graphic_console_init() build failure Andreas Färber
2014-03-07 22:36 ` Don Slutz
2014-03-08 6:47 ` Stefan Weil
@ 2014-03-08 12:09 ` Peter Maydell
2 siblings, 0 replies; 4+ messages in thread
From: Peter Maydell @ 2014-03-08 12:09 UTC (permalink / raw)
To: Andreas Färber; +Cc: QEMU Developers, Gerd Hoffmann
On 7 March 2014 21:42, Andreas Färber <afaerber@suse.de> wrote:
> In commit 5643706a095044d75df1c0588aac553a595b972b (console: add head
> to index to qemu consoles.) graphic_console_init() was extended to take
> an additional argument, but xenfb was not updated accordingly. Fix it.
>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
Applied to master, thanks. I've installed the xen dev libraries on
my build box, so I should be able to catch xen build failures
in future.
-- PMM
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-08 12:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-07 21:42 [Qemu-devel] [PATCH buildfix] xenfb: Fix graphic_console_init() build failure Andreas Färber
2014-03-07 22:36 ` Don Slutz
2014-03-08 6:47 ` Stefan Weil
2014-03-08 12:09 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).