Re: [Qemu-devel] [PATCH buildfix] xenfb: Fix graphic_console_init() build failure

[Stefan Weil <sw@weilnetz.de>]

Am 07.03.2014 22:42, schrieb Andreas Färber:
> In commit 5643706a095044d75df1c0588aac553a595b972b (console: add head
> to index to qemu consoles.) graphic_console_init() was extended to take
> an additional argument, but xenfb was not updated accordingly. Fix it.
> 
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  hw/display/xenfb.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c
> index cb9d456..032eb7a 100644
> --- a/hw/display/xenfb.c
> +++ b/hw/display/xenfb.c
> @@ -992,7 +992,7 @@ wait_more:
>  
>      /* vfb */
>      fb = container_of(xfb, struct XenFB, c.xendev);
> -    fb->c.con = graphic_console_init(NULL, &xenfb_ops, fb);
> +    fb->c.con = graphic_console_init(NULL, 0, &xenfb_ops, fb);
>      fb->have_console = 1;
>  
>      /* vkbd */
> 


Same problem here. There is also a 2nd call of that function in the same
file, but it is currently disabled by #if 0...#endif.

Reviewed-by: Stefan Weil <sw@weilnetz.de>