From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMB2t-0001ZS-Tq for qemu-devel@nongnu.org; Sat, 08 Mar 2014 01:47:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WMB2p-000413-6w for qemu-devel@nongnu.org; Sat, 08 Mar 2014 01:47:43 -0500 Received: from [2a03:4000:1::4e2f:c7ac:d] (port=57119 helo=v220110690675601.yourvserver.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMB2o-00040w-WE for qemu-devel@nongnu.org; Sat, 08 Mar 2014 01:47:39 -0500 Message-ID: <531ABCFD.6050607@weilnetz.de> Date: Sat, 08 Mar 2014 07:47:25 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1394228528-31625-1-git-send-email-afaerber@suse.de> In-Reply-To: <1394228528-31625-1-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH buildfix] xenfb: Fix graphic_console_init() build failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, Gerd Hoffmann Am 07.03.2014 22:42, schrieb Andreas F=C3=A4rber: > In commit 5643706a095044d75df1c0588aac553a595b972b (console: add head > to index to qemu consoles.) graphic_console_init() was extended to take > an additional argument, but xenfb was not updated accordingly. Fix it. >=20 > Cc: Gerd Hoffmann > Signed-off-by: Andreas F=C3=A4rber > --- > hw/display/xenfb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/hw/display/xenfb.c b/hw/display/xenfb.c > index cb9d456..032eb7a 100644 > --- a/hw/display/xenfb.c > +++ b/hw/display/xenfb.c > @@ -992,7 +992,7 @@ wait_more: > =20 > /* vfb */ > fb =3D container_of(xfb, struct XenFB, c.xendev); > - fb->c.con =3D graphic_console_init(NULL, &xenfb_ops, fb); > + fb->c.con =3D graphic_console_init(NULL, 0, &xenfb_ops, fb); > fb->have_console =3D 1; > =20 > /* vkbd */ >=20 Same problem here. There is also a 2nd call of that function in the same file, but it is currently disabled by #if 0...#endif. Reviewed-by: Stefan Weil