From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39736)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WMYC1-0001ue-Bt
	for qemu-devel@nongnu.org; Sun, 09 Mar 2014 03:30:47 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WMYBv-0006An-R5
	for qemu-devel@nongnu.org; Sun, 09 Mar 2014 03:30:41 -0400
Received: from mail-ee0-x234.google.com ([2a00:1450:4013:c00::234]:43206)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WMYBv-00069r-JT
	for qemu-devel@nongnu.org; Sun, 09 Mar 2014 03:30:35 -0400
Received: by mail-ee0-f52.google.com with SMTP id e49so2470887eek.25
	for <qemu-devel@nongnu.org>; Sat, 08 Mar 2014 23:30:33 -0800 (PST)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <531C1894.8020804@redhat.com>
Date: Sun, 09 Mar 2014 08:30:28 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1394304438-14848-1-git-send-email-l@dorileo.org>
	<1394304438-14848-3-git-send-email-l@dorileo.org>
In-Reply-To: <1394304438-14848-3-git-send-email-l@dorileo.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH RFC 2/2] qemu-img: migrate to use qemu-arg
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Leandro Dorileo <l@dorileo.org>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Peter Maydell <peter.maydell@linaro.org>, Fam Zheng <famz@redhat.com>, Stefan Weil <sw@weilnetz.de>, Michael Tokarev <mjt@tls.msk.ru>, Stefan Hajnoczi <stefanha@redhat.com>, Laszlo Ersek <lersek@redhat.com>, Peter Lieven <pl@kamp.de>

Il 08/03/2014 19:47, Leandro Dorileo ha scritto:
> Remove the arg parsing implementations using getopt and use qemu-arg.
> Also remove the qemu-img-cmds.hx since it's now generated on building time,
> adapted the build system to generate the .hx file using the qemu-img itself
> using the qemu-arg internal command generate-hx.
>
> Signed-off-by: Leandro Dorileo <l@dorileo.org>

This makes it much harder to cross-compile QEMU.  Also, I wonder how 
hard it would be to apply the same approach to the main QEMU binary 
which already uses QemuOpts for its more complex arguments; for sure you 
risk that accumulating multiple layers of abstractions makes the code 
even harder to read than it is now.

Paolo