From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMlAi-0004e9-Lo for qemu-devel@nongnu.org; Sun, 09 Mar 2014 17:22:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WMlAc-0006tX-MH for qemu-devel@nongnu.org; Sun, 09 Mar 2014 17:22:12 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2113) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WMlAc-0006tC-EF for qemu-devel@nongnu.org; Sun, 09 Mar 2014 17:22:06 -0400 Message-ID: <531CDB79.6050700@redhat.com> Date: Sun, 09 Mar 2014 17:22:01 -0400 From: "Jeff E. Nelson" MIME-Version: 1.0 References: <1394388381-22813-1-git-send-email-mst@redhat.com> In-Reply-To: <1394388381-22813-1-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v3 1/3] loader: rename in_ram/has_mr Reply-To: jen@redhat.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: pbonzini@redhat.com, jeff.nelson@redhat.com, lersek@redhat.com, dgilbert@redhat.com, Anthony Liguori On 03/09/2014 02:06 PM, Michael S. Tsirkin wrote: > we put copy of ROMs in MR for migration. > but the name rom_in_ram makes one think we > load it in guest RAM. > Rename has_mr to make intent clearer. > > Signed-off-by: Michael S. Tsirkin > --- > include/hw/loader.h | 2 +- > hw/core/loader.c | 6 +++--- > hw/i386/pc_piix.c | 2 +- > hw/i386/pc_q35.c | 2 +- > 4 files changed, 6 insertions(+), 6 deletions(-) > > diff --git a/include/hw/loader.h b/include/hw/loader.h > index aaf08c3..3dc5b94 100644 > --- a/include/hw/loader.h > +++ b/include/hw/loader.h > @@ -49,7 +49,7 @@ void pstrcpy_targphys(const char *name, > hwaddr dest, int buf_size, > const char *source); > > -extern bool rom_file_in_ram; > +extern bool rom_file_has_mr; Thank you! It is much easier to understand what is going on. I don't think I am qualified to offer an official acknowledgment, but this looks good to me. -Jeff > > int rom_add_file(const char *file, const char *fw_dir, > hwaddr addr, int32_t bootindex); > diff --git a/hw/core/loader.c b/hw/core/loader.c > index b323c0c..13e98d8 100644 > --- a/hw/core/loader.c > +++ b/hw/core/loader.c > @@ -54,7 +54,7 @@ > > #include > > -bool rom_file_in_ram = true; > +bool rom_file_has_mr = true; > > static int roms_loaded; > > @@ -694,7 +694,7 @@ int rom_add_file(const char *file, const char *fw_dir, > basename); > snprintf(devpath, sizeof(devpath), "/rom@%s", fw_file_name); > > - if (rom_file_in_ram) { > + if (rom_file_has_mr) { > data = rom_set_mr(rom, OBJECT(fw_cfg), devpath); > } else { > data = rom->data; > @@ -738,7 +738,7 @@ void *rom_add_blob(const char *name, const void *blob, size_t len, > > snprintf(devpath, sizeof(devpath), "/rom@%s", fw_file_name); > > - if (rom_file_in_ram) { > + if (rom_file_has_mr) { > data = rom_set_mr(rom, OBJECT(fw_cfg), devpath); > } else { > data = rom->data; > diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c > index ae1699d..fb2d636 100644 > --- a/hw/i386/pc_piix.c > +++ b/hw/i386/pc_piix.c > @@ -272,7 +272,7 @@ static void pc_compat_1_6(QEMUMachineInitArgs *args) > { > pc_compat_1_7(args); > has_pci_info = false; > - rom_file_in_ram = false; > + rom_file_has_mr = false; > has_acpi_build = false; > } > > diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c > index a7f6260..eb55ae4 100644 > --- a/hw/i386/pc_q35.c > +++ b/hw/i386/pc_q35.c > @@ -250,7 +250,7 @@ static void pc_compat_1_6(QEMUMachineInitArgs *args) > { > pc_compat_1_7(args); > has_pci_info = false; > - rom_file_in_ram = false; > + rom_file_has_mr = false; > has_acpi_build = false; > } > > -- - Jeff E. Nelson / Red Hat / Virtualization / jen@redhat.com