From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45219)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WMv0t-00039A-LX
	for qemu-devel@nongnu.org; Mon, 10 Mar 2014 03:52:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WMv0l-0006fw-86
	for qemu-devel@nongnu.org; Mon, 10 Mar 2014 03:52:43 -0400
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <531D6F37.2050700@redhat.com>
Date: Mon, 10 Mar 2014 08:52:23 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1394410549-13751-1-git-send-email-afaerber@suse.de>
	<1394410549-13751-10-git-send-email-afaerber@suse.de>
In-Reply-To: <1394410549-13751-10-git-send-email-afaerber@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH qom-cpu v2 09/40] cpu: Turn
 cpu_handle_mmu_fault() into a CPUClass hook
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Jia Liu <proljc@gmail.com>, Anthony Green <green@moxielogic.com>, Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>, Michael Walle <michael@walle.cc>, PowerPC <qemu-ppc@nongnu.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Guan Xuetao <gxt@mprc.pku.edu.cn>, Aurelien Jarno <aurelien@aurel32.net>, Richard Henderson <rth@twiddle.net>

Il 10/03/2014 01:15, Andreas Färber ha scritto:
> Note that while such functions may exist both for *-user and softmmu,
> only *-user uses the CPUState hook, while softmmu reuses the prototype
> for calling it directly.

I'm not sure I understand why you omit the hook for *-softmmu.  It 
doesn't hurt to have it, does it?

Paolo