From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:35543)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WN2el-0002Fh-FO
	for qemu-devel@nongnu.org; Mon, 10 Mar 2014 12:02:32 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WN2ed-0005lI-2x
	for qemu-devel@nongnu.org; Mon, 10 Mar 2014 12:02:23 -0400
Received: from mail-qc0-x233.google.com ([2607:f8b0:400d:c01::233]:36136)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1WN2ec-0005l0-RK
	for qemu-devel@nongnu.org; Mon, 10 Mar 2014 12:02:14 -0400
Received: by mail-qc0-f179.google.com with SMTP id m20so7818566qcx.24
	for <qemu-devel@nongnu.org>; Mon, 10 Mar 2014 09:02:12 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <531DE1F6.2060306@twiddle.net>
Date: Mon, 10 Mar 2014 09:01:58 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1394043257-4800-1-git-send-email-rth@twiddle.net>
	<CAFEAcA9AkR4phwYo1WCPdGBvC6trF9uTyWgS2HNCTUOno8rp1Q@mail.gmail.com>
In-Reply-To: <CAFEAcA9AkR4phwYo1WCPdGBvC6trF9uTyWgS2HNCTUOno8rp1Q@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] target-arm: Fix intptr_t vs tcg_target_long
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>

On 03/10/2014 05:08 AM, Peter Maydell wrote:
> A quick grep of the uses of tcg_gen_exit_tb() suggests
> we would be better to change this function to take
> (TranslationBlock *tb, int tb_exit_code), possibly
> also with a special case for 0 if "tcg_gen_exit_tb(NULL, 0)"
> seems too verbose.

No, since the goto_tb cases use (tb | n), so you wind up casting to an integer
type anyway.


r~