From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36606) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WN2iX-0005sR-Fk for qemu-devel@nongnu.org; Mon, 10 Mar 2014 12:06:23 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WN2iT-0007NB-6D for qemu-devel@nongnu.org; Mon, 10 Mar 2014 12:06:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37033) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WN2iS-0007N2-Tf for qemu-devel@nongnu.org; Mon, 10 Mar 2014 12:06:13 -0400 Message-ID: <531DE2EA.8000101@redhat.com> Date: Mon, 10 Mar 2014 10:06:02 -0600 From: Eric Blake MIME-Version: 1.0 References: <1394451098-296108-1-git-send-email-anton.ivanov@kot-begemot.co.uk> In-Reply-To: <1394451098-296108-1-git-send-email-anton.ivanov@kot-begemot.co.uk> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="90EvpFcAosxgqoaHp4oI1DHMQp7RjIvDT" Subject: Re: [Qemu-devel] [PATCH] net: L2TPv3 transport List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anton.ivanov@kot-begemot.co.uk, qemu-devel@nongnu.org Cc: Anton Ivanov , pbonzini@redhat.com, afaerber@suse.de, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --90EvpFcAosxgqoaHp4oI1DHMQp7RjIvDT Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/10/2014 05:31 AM, anton.ivanov@kot-begemot.co.uk wrote: > From: Anton Ivanov When sending revisions of a patch sent earlier, be sure to include 'PATCHv2' (or higher, as appropriate) in the subject,... >=20 > This tranport allows to connect a qemu nic to a static Ethernet > over L2TPv3 tunnel. The transport supports all options present > in the linux kernel implementation. It allows qemu to connect > to any linux host running kernel 3.3+, most routers and network >=20 > Signed-off-by: Anton Ivanov > --- =2E..and describe what changed from v1 after the --- separator. That way= , earlier reviewers will know what differences to look for, instead of assuming it is a brand new patch. > +++ b/qapi-schema.json > @@ -2940,6 +2940,60 @@ > '*localaddr': 'str', > '*udp': 'str' } } > =20 > +# @NetdevL2TPv3Options Missing a ## line prior to the struct name. > +# @pincounter: #optional pin sequence counter to zero - workaround for= buggy implementations or networks with packet reorder Super long line. Please wrap at 80 columns. > +# > +# @txcookie: #optional 32 or 64 bit transmit cookie > +# > +# @rxcookie: #optional 32 or 64 bit receive cookie > +# > +# @txsession: 32 bit transmit session > +# > +# @rxsession: 32 bit receive session - if not specified set to the sam= e value as transmit > +# > +# @optional: additional offset - allows the insertion of additional ap= plication-specific data before the packet payload Another long line. Also, you don't have a variable named 'optional'; you probably meant '@offset: #optional'. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --90EvpFcAosxgqoaHp4oI1DHMQp7RjIvDT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTHeLqAAoJEKeha0olJ0Nq9zMH/1J7hfeewDF4Q2gnS2C3pog/ M1Uy4y8tmfpRc6j6+Z56C1NxMHn7WWN7pFzHusblp/PhLl/OTsTtf+0tdJrOAk/M 3wQHcZEnRxLXugjVcnTIzE6oQjsFW/Hgex+nKerxszO8Gh05+CTk2fgJXWXu0yp1 II2/EmlVUYPy2xEYy8whTqpqfb3+63ExnBHrQAFUzIbWPaLwiN2EATneAJs29Y3Y bAG0o1/g9uWR0V8rCvu/f86I1vDJnFMp6e6Ii+/iOMxCWDZsyy/QU5c0BIKeEsLs xGjcc5we7a7OI2ZgzdgP8rwzwDl5XCk3OTjQmtyk9op2RqHr4lE8bLboeAsECXk= =sbXX -----END PGP SIGNATURE----- --90EvpFcAosxgqoaHp4oI1DHMQp7RjIvDT--