From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35332) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNHi6-0003uM-Cq for qemu-devel@nongnu.org; Tue, 11 Mar 2014 04:06:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNHi0-0003UQ-Br for qemu-devel@nongnu.org; Tue, 11 Mar 2014 04:06:50 -0400 Received: from mx1.redhat.com ([209.132.183.28]:64998) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNHi0-0003UM-2x for qemu-devel@nongnu.org; Tue, 11 Mar 2014 04:06:44 -0400 Message-ID: <531EC40B.8020207@redhat.com> Date: Tue, 11 Mar 2014 09:06:35 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1394230667-17037-1-git-send-email-sw@weilnetz.de> <1394230667-17037-5-git-send-email-sw@weilnetz.de> <20140310151713.GD32400@stefanha-thinkpad.redhat.com> <531E05C2.8080208@weilnetz.de> In-Reply-To: <531E05C2.8080208@weilnetz.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 4/5] w32: Replace Windows specific data types in common header files List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil , Stefan Hajnoczi Cc: kwolf@redhat.com, peter.maydell@linaro.org, Anthony Liguori , qemu-devel@nongnu.org, stefanha@redhat.com, =?ISO-8859-1?Q?Andreas_F=E4rber?= Il 10/03/2014 19:34, Stefan Weil ha scritto: > As you noticed, the problem is include/qemu/thread.h which includes > include/qemu/thread-win32.h to define QemuMutex. Unfortunately, > QemuMutex is used by value in include/block/aio.h and in > include/exec/cpu-all.h. Most QEMU files depend on these two files. > Breaking the dependencies of all those files on windows.h is essential > for my patch series. I see only three solutions: > > * Leave the code as it is. That implies long compile time for MinGW > builds and name space pollution because nearly every compilation needs > windows.h. This last point is the reason for two existing hacks and one > more hack which is still needed (both Peter and I sent patches for it), > and we have a realistic chance to need future hacks from time to time. > > * Break the dependency on windows.h by using QEMU data types instead of > Windows API data types. > > * Break the dependency on windows.h by avoiding the use of certain QEMU > data types (especially QemuMutex) by value, because those QEMU data > types use Windows data types. > > I must admit that I tried that third solution and gave up after a while. > > What do you suggest to do? For me, any of the three alternatives is > fine. I have no personal use for QEMU on Windows, nor do I need it for > my professional work any longer. Any solution is fine. I don't like particularly this series, but I don't dislike it enough to override your judgement as Win32 maintainer. I agree with Markus about not liking the comments on the #include lines, though. Paolo