From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44207) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNLU6-0007dw-BV for qemu-devel@nongnu.org; Tue, 11 Mar 2014 08:08:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNLU1-00074M-D1 for qemu-devel@nongnu.org; Tue, 11 Mar 2014 08:08:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:26644) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNLU1-00074F-3d for qemu-devel@nongnu.org; Tue, 11 Mar 2014 08:08:33 -0400 Message-ID: <531EFC81.5000703@redhat.com> Date: Tue, 11 Mar 2014 06:07:29 -0600 From: Eric Blake MIME-Version: 1.0 References: <1394532550-21857-1-git-send-email-marcel.a@redhat.com> <1394532550-21857-3-git-send-email-marcel.a@redhat.com> In-Reply-To: <1394532550-21857-3-git-send-email-marcel.a@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="T9ngUam9gH0PWuAk3g8rCmQ5h66BRCHOJ" Subject: Re: [Qemu-devel] [PATCH V2 2/2] tests: Tweak the Makefile to produce per-test output. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , qemu-devel@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, aliguori@amazon.com, stefanha@redhat.com, afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --T9ngUam9gH0PWuAk3g8rCmQ5h66BRCHOJ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/11/2014 04:09 AM, Marcel Apfelbaum wrote: > From: Stefan Hajnoczi >=20 > The effect is that the output will grow, but we will know > which qtest failed. This helps when an asert is made on s/asert/assert/ > other code and not in the test itself. >=20 > Signed-off-by: Stefan Hajnoczi > Signed-off-by: Marcel Apfelbaum > --- > tests/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/tests/Makefile b/tests/Makefile > index b17d41e..a8405c8 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -273,7 +273,7 @@ check-help: > @echo "changed with variable GTESTER_OPTIONS." > =20 > SPEED =3D quick > -GTESTER_OPTIONS =3D -k $(if $(V),--verbose,-q) > +GTESTER_OPTIONS =3D -k #$(if $(V),--verbose,-q) Isn't this effectively commenting out the rest of the line? If so, why not delete everything after the #? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --T9ngUam9gH0PWuAk3g8rCmQ5h66BRCHOJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTHvyBAAoJEKeha0olJ0NqINsH/jSaiGn5PHoeMI8VSKjUNk5v rq6YquCETdYFOV88JLNoCBMJ1qyo46dCChh4GF4azQg8EVikRMiUIcDg2yPL7XeK 1DH0+99FoYQxJSOiUhSOqqIMqHuABVTioCMnef6bsl8em7v9GZnWpwif5wGqOUqc E/+NqnUxpEibHKteAIn5N/qw6GlJLHJVYYze2y2Iysk4kTWLtDvuC30/tXAC5dws uNeKhs+wwTr9FkgRkYJT0vs7SnGFvzX9LCsrCvZIQ/BrLQ3XUWMu9OsqzjrKWzGG GAlGoWKDagXFnXimqvWp2vbRKtwmroB3WhRRl5d3x1bLGk1bm2SGP6jWGl/9y1s= =dHte -----END PGP SIGNATURE----- --T9ngUam9gH0PWuAk3g8rCmQ5h66BRCHOJ--