From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNLwN-0002RD-IY for qemu-devel@nongnu.org; Tue, 11 Mar 2014 08:37:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNLwI-0000WA-HY for qemu-devel@nongnu.org; Tue, 11 Mar 2014 08:37:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:13365) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNLwI-0000Vy-77 for qemu-devel@nongnu.org; Tue, 11 Mar 2014 08:37:46 -0400 Message-ID: <531F026A.1030802@redhat.com> Date: Tue, 11 Mar 2014 06:32:42 -0600 From: Eric Blake MIME-Version: 1.0 References: <1394540689-26672-1-git-send-email-marcel.a@redhat.com> In-Reply-To: <1394540689-26672-1-git-send-email-marcel.a@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="fU56Hb04e8pD7rr35k61xuVIqG5V23S61" Subject: Re: [Qemu-devel] [PATCH V3 0/2] tests: Fix possible deadlock in qtest initialization List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , qemu-devel@nongnu.org Cc: kwolf@redhat.com, armbru@redhat.com, aliguori@amazon.com, stefanha@redhat.com, afaerber@suse.de This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --fU56Hb04e8pD7rr35k61xuVIqG5V23S61 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/11/2014 06:24 AM, Marcel Apfelbaum wrote: > V2 -> V3: > Addressed Eric Blake's review: > - Corrected a typo. > - Replace the commented Makefile part >=20 > V1 -> V2: > Addressed Stefan Hajnoczi's review: > - Dropped qtest_state_valid API > - Moved socket options in socket_accept.=20 >=20 > 'socket_accept' waits for Qemu to initialize its unix socket. > If Qemu encounters an error during command line parsing, > it can exit before initializing the communication channel. >=20 > Using a timeout for sockets fixes the issue, but is not > enough. We need to know which test from check-qtest-* > fails. >=20 > We tweak the Makefile to produce per-test output. > The effect is that the output will grow, but we will know > which qtest failed. This helps when an assert is made on > other code and not in the test itself. >=20 Series: Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --fU56Hb04e8pD7rr35k61xuVIqG5V23S61 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTHwJrAAoJEKeha0olJ0NqM/8H/3PxWzN7PReyGu3THZynQa3D GTQWCaZQUAZi8PznI4FQzXJXExh1KrpIP2c8Bc8rWo2r8FpUv+4n1WqDypJDZ4vn qiNdqEuBH4PHw4MoHpLhxyxNXVafBARZ4uZIrtqmIDTOPPvyQJTg4nP1l9xVQkpI gY6UPbH4Oyg4esYQJAZEWKJ5shlPutsu2FXgoX1QYzxNHm1sgZBHjq32dgXBy2Jm 6TV30S+6Q70xaDbZlbbFVfhm3hZpeBPnsu7YbkdMKj2j6HaehqmbEXNBCaoUiGQ0 bSmnQhPmjAXYYCikhpgZrAw51bGZo0p3qw2EIYnRsfeo008dmt+646BbdIfwTdg= =fkN4 -----END PGP SIGNATURE----- --fU56Hb04e8pD7rr35k61xuVIqG5V23S61--