From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33371) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNMQn-0003ee-N8 for qemu-devel@nongnu.org; Tue, 11 Mar 2014 09:09:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNMQj-0003av-Q9 for qemu-devel@nongnu.org; Tue, 11 Mar 2014 09:09:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30312) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNMQj-0003ap-IO for qemu-devel@nongnu.org; Tue, 11 Mar 2014 09:09:13 -0400 Message-ID: <531F0AF2.8060301@redhat.com> Date: Tue, 11 Mar 2014 07:09:06 -0600 From: Eric Blake MIME-Version: 1.0 References: <1394542415-5152-1-git-send-email-arei.gonglei@huawei.com> <1394542415-5152-3-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1394542415-5152-3-git-send-email-arei.gonglei@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BQ1B3kLgrp559iwvfpq5nFiUXO2nKbuhk" Subject: Re: [Qemu-devel] [PATCH 02/10] migration: Add counters of updating the dirty bitmap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: ChenLiang , owasserm@redhat.com, pbonzini@redhat.com, weidong.huang@huawei.com, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BQ1B3kLgrp559iwvfpq5nFiUXO2nKbuhk Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/11/2014 06:53 AM, arei.gonglei@huawei.com wrote: > From: ChenLiang >=20 > Add counters to log the times of updating the dirty bitmap. >=20 > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > Reviewed-by: Dr. David Alan Gilbert > Reviewed-by: Eric Blake Wait - how did my Reviewed-by get here? There is no [PATCHv2] in the subject line to indicate that I reviewed an earlier revision. and the only other mail I see from me in the archives with the same subject line is here: https://lists.gnu.org/archive/html/qemu-devel/2014-02/msg05143.html where I made a comment, but did NOT give my signature on the patch. Please follow http://wiki.qemu.org/Contribute/SubmitAPatch when using Reviewed-by: tags and subject lines. Otherwise, you are making life harder for yourself and for reviewers. > --- > arch_init.c | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) >=20 > diff --git a/arch_init.c b/arch_init.c > index 2ac68c2..37e4aa5 100644 > --- a/arch_init.c > +++ b/arch_init.c > @@ -110,6 +110,23 @@ static bool mig_throttle_on; > static int dirty_rate_high_cnt; > static void check_guest_throttling(void); > =20 > +static uint64_t bitmap_sync_cnt; > +/* the functions *_bitmap_sync_cnt only run in migrate thread */ > +static inline void reset_bitmap_sync_cnt(void) Isn't static inline a bit much in a .c file? You generally want inline functions to appear in .h. For this particular file, I think these functions are overkill... > =20 > + increase_bitmap_sync_cnt(); and that you could just directly write 'bitmap_sync_cnt++' here. When you send v3, do NOT add my Reviewed-by yet, because I still want to make sure that the new version is correct. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --BQ1B3kLgrp559iwvfpq5nFiUXO2nKbuhk Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTHwryAAoJEKeha0olJ0Nq/8cH/13IZED99XhH1r6Xqk24J1vf 6TL8hXVmgDA/qgtr9ZcMnxSPNcciXKsRP3g2/kvi6dddkIwQYb7gGXzDgNj70vT5 RUEccabLbXXUx2UmLltqHZlgpqFbZRM8sV4qO5uOU+tBxLHFO2R2gxYnEaeStSG2 /AZY2F/k7SL7KorZq9aC3bSOmtPHUI7Tphvq9loRjXru+g7XaWOp7oUKZ8IrNYrx A4Ij3IG3Ez3CWcXGZI45J4MZzFE+P1Miw9M/xa0/THsHQIrtjYOVZk+PNTpmXNUh 7Sh4vRcnvBxuJL/OQmqfUDkVxb3obySHE82lJPA4t5zrq4vkCQ80cZHbxfddCks= =X4gu -----END PGP SIGNATURE----- --BQ1B3kLgrp559iwvfpq5nFiUXO2nKbuhk--