From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34281) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNMTO-000640-4y for qemu-devel@nongnu.org; Tue, 11 Mar 2014 09:12:02 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNMTJ-0004OQ-QR for qemu-devel@nongnu.org; Tue, 11 Mar 2014 09:11:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:30732) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNMTJ-0004OL-HZ for qemu-devel@nongnu.org; Tue, 11 Mar 2014 09:11:53 -0400 Message-ID: <531F0B8F.8070107@redhat.com> Date: Tue, 11 Mar 2014 07:11:43 -0600 From: Eric Blake MIME-Version: 1.0 References: <1394542415-5152-1-git-send-email-arei.gonglei@huawei.com> <1394542415-5152-5-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1394542415-5152-5-git-send-email-arei.gonglei@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="jgoRS1cQT7MCG2LRjUUQBonobL6kIKuoU" Subject: Re: [Qemu-devel] [PATCH 04/10] XBZRLE: rebuild the cache_is_cached function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: ChenLiang , owasserm@redhat.com, pbonzini@redhat.com, weidong.huang@huawei.com, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --jgoRS1cQT7MCG2LRjUUQBonobL6kIKuoU Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/11/2014 06:53 AM, arei.gonglei@huawei.com wrote: > From: ChenLiang >=20 > Rebuild the cache_is_cached function. >=20 > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > Reviewed-by: Dr. David Alan Gilbert > Reviewed-by: Eric Blake Once again, I did NOT give R-b in v1. > --- > page_cache.c | 33 +++++++++++++++------------------ > 1 file changed, 15 insertions(+), 18 deletions(-) >=20 > + if (it->it_addr =3D=3D addr) { > + /* updata the it_age when the cache hit */ Furthermore, I made a review comment in v1 that you had a typo, but it went unchanged in this version: s/updata/update/ --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --jgoRS1cQT7MCG2LRjUUQBonobL6kIKuoU Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTHwuPAAoJEKeha0olJ0NqRFoH+wcyCW91W0L7doyUIQhsd3VU w/9g7JWSdz+eSjaNi5ctTlfQunLSS0iIDBhEr1ZfW6zXJTAoj+XhMrtpoV57Gw76 Qzeka3160D++TPc0XTmUwJS39ZQ92BYktE5ml+Sk3+etauqE7URvMyGEGS6cmIuF CXMcZd7PbyM9BEbUoRINR8dWQGhnAh4wnL/0RXc7IB8gltH330QT/y4b1ZzV79Dp /FboaRSx2dr48Qqd4WmbHydc/50kaLMyJVbYRbOJTWAGhxzimpiCdLOrd8DiOkAm UQ9QYofKw9GP7pU9ykAEY/76qgyvnImO3wrUDAsep5xslyoW4q9dYhbaryiD5CA= =bKiB -----END PGP SIGNATURE----- --jgoRS1cQT7MCG2LRjUUQBonobL6kIKuoU--