From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37874) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNMdd-00018Z-Qq for qemu-devel@nongnu.org; Tue, 11 Mar 2014 09:22:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNMdZ-0008Jh-0q for qemu-devel@nongnu.org; Tue, 11 Mar 2014 09:22:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:4108) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNMdY-0008JK-Ot for qemu-devel@nongnu.org; Tue, 11 Mar 2014 09:22:28 -0400 Message-ID: <531F0E0D.7090901@redhat.com> Date: Tue, 11 Mar 2014 07:22:21 -0600 From: Eric Blake MIME-Version: 1.0 References: <1394542415-5152-1-git-send-email-arei.gonglei@huawei.com> <1394542415-5152-10-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1394542415-5152-10-git-send-email-arei.gonglei@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Sm1IkRJ684laRUJBl7Sh2f4f8luaQH4os" Subject: Re: [Qemu-devel] [PATCH 09/10] migration: expose the bitmap_sync_cnt to the end user List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: ChenLiang , owasserm@redhat.com, pbonzini@redhat.com, weidong.huang@huawei.com, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Sm1IkRJ684laRUJBl7Sh2f4f8luaQH4os Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/11/2014 06:53 AM, arei.gonglei@huawei.com wrote: > From: ChenLiang >=20 > expose the counter that log the times of updating the dirty bitmap to > end user. >=20 > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > --- > +++ b/qapi-schema.json > @@ -651,13 +651,15 @@ > # > # @mbps: throughput in megabits/sec. (since 1.6) > # > +# @dirty-sync-cnt: the times of ram dirty sync (since 1.7) The earliest this will make it in is 2.0 - and that's if it is treated as a bug fix. Otherwise, this needs to be '(since 2.1)'. 'cnt' is an abbreviation; it doesn't hurt to spell things out to say 'dirty-sync-count'. > @@ -2966,6 +2967,7 @@ Examples: > "duplicate":123, > "normal":123, > "normal-bytes":123456 > + "dirty-sync-cnt":15 Invalid JSON. If dirty-sync-cnt is present, "normal-bytes":123456 must have a comma separating the two elements. > } > } > } > @@ -2991,6 +2993,7 @@ Examples: > "duplicate":123, > "normal":123, > "normal-bytes":123456 > + "dirty-sync-cnt":15 And again. All of your insertions to this example need correction. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Sm1IkRJ684laRUJBl7Sh2f4f8luaQH4os Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTHw4NAAoJEKeha0olJ0Nqhw4H/1zAq+rLuiw9yaehYJzJ9AFH +pOoEWlgLWhYny2V4EHhLi1IicRqEvwvQrqlw/R3iMTw6KjV03bUjKpLGtREFuXl 0ruvX7Hym4pKe8e2knm30Gs27MY6Ijx821u8yRHKmkxPhbpyE1xElYkEf3hlwlLd KwrA6oEpckKAbyNX/8JJVdcI156v5enQ9heYGN99XeCeby8nyFKRFtPeTv2xJiw6 8a4G4jXeWkrnTSu53MBxzP25/nG4ddBCCDKoDSnw0IeE4ufmhalZY0454R9t02qD jGqEGiH6Zq286Qvr6Vg3q/RI3jigovmH26f7Rwzeo3vxHkfDzEDTrsaoV/HMi+w= =IOrk -----END PGP SIGNATURE----- --Sm1IkRJ684laRUJBl7Sh2f4f8luaQH4os--