From: Eric Blake <eblake@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>, qemu-devel@nongnu.org
Cc: stefanha@redhat.com
Subject: Re: [Qemu-devel] [PATCH] qcow2: Don't write with BDRV_O_INCOMING
Date: Tue, 11 Mar 2014 09:25:28 -0600 [thread overview]
Message-ID: <531F2AE8.7090908@redhat.com> (raw)
In-Reply-To: <1394547303-9154-1-git-send-email-kwolf@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 791 bytes --]
On 03/11/2014 08:15 AM, Kevin Wolf wrote:
> qcow2_open() causes writes when repairing an image with the dirty flag
> set and when clearing autoclear flags. It shouldn't do this when another
> qemu instance is still actively working on this image file.
>
> One effect of the bug is that images may have a cleared dirty flag while
> the migration source host still has it in use with lazy refcounts
> enabled, so refcounts are not accurate and the dirty flag must remain
> set.
>
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/qcow2.c | 12 +++++++-----
> 1 file changed, 7 insertions(+), 5 deletions(-)
Reviewed-by: Eric Blake <eblake@redhat.com>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
next prev parent reply other threads:[~2014-03-11 15:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 14:15 [Qemu-devel] [PATCH] qcow2: Don't write with BDRV_O_INCOMING Kevin Wolf
2014-03-11 15:25 ` Eric Blake [this message]
2014-03-11 18:45 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531F2AE8.7090908@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).