From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNOYk-0005Xl-3r for qemu-devel@nongnu.org; Tue, 11 Mar 2014 11:25:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNOYd-0000w9-Va for qemu-devel@nongnu.org; Tue, 11 Mar 2014 11:25:38 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50784) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNOYd-0000vr-N3 for qemu-devel@nongnu.org; Tue, 11 Mar 2014 11:25:31 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2BFPU3s012522 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 11 Mar 2014 11:25:30 -0400 Message-ID: <531F2AE8.7090908@redhat.com> Date: Tue, 11 Mar 2014 09:25:28 -0600 From: Eric Blake MIME-Version: 1.0 References: <1394547303-9154-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1394547303-9154-1-git-send-email-kwolf@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Ddi6rhX6AiC4bE3om5IA3JffA8j9DtrJJ" Subject: Re: [Qemu-devel] [PATCH] qcow2: Don't write with BDRV_O_INCOMING List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Ddi6rhX6AiC4bE3om5IA3JffA8j9DtrJJ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/11/2014 08:15 AM, Kevin Wolf wrote: > qcow2_open() causes writes when repairing an image with the dirty flag > set and when clearing autoclear flags. It shouldn't do this when anothe= r > qemu instance is still actively working on this image file. >=20 > One effect of the bug is that images may have a cleared dirty flag whil= e > the migration source host still has it in use with lazy refcounts > enabled, so refcounts are not accurate and the dirty flag must remain > set. >=20 > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 12 +++++++----- > 1 file changed, 7 insertions(+), 5 deletions(-) Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Ddi6rhX6AiC4bE3om5IA3JffA8j9DtrJJ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTHyroAAoJEKeha0olJ0NqhxIIAIV4/4qUKEaRxCO2ub4FlS8v ArTmlnj62NT++5mT4jxdWlp+gp6jIun5w4jE5Z5i7MJ8th82Se+FrNMLyw9Drl3T P5nNEZNrT3xDGwTzrnTcnE7coMONZi50zZ9eCh0fjelSakVI+EEBGQpr2xrvQHEp Hav4qgKPs3FEcSaBCIYRTKiYO0lKQjDzbwZX3rDc1+k5coXv6MPV2qFobN6OsmYV N6tueGdHS7gwiidSYTwweeVs+m5gFJ3BI+Y20VSjcEkDrihceumJLXU+PrZuAJqq pcKDhXsJWoov7Ph/UvpAbHg+z/H/+0Nwo8zREJJy0Dl0dwCdRjkfl6cj66Gg03c= =mJlZ -----END PGP SIGNATURE----- --Ddi6rhX6AiC4bE3om5IA3JffA8j9DtrJJ--