From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42522) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNObf-0001pw-TB for qemu-devel@nongnu.org; Tue, 11 Mar 2014 11:28:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNObb-0001qy-HQ for qemu-devel@nongnu.org; Tue, 11 Mar 2014 11:28:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNObb-0001q6-8t for qemu-devel@nongnu.org; Tue, 11 Mar 2014 11:28:35 -0400 Message-ID: <531F2B9F.2010404@redhat.com> Date: Tue, 11 Mar 2014 09:28:31 -0600 From: Eric Blake MIME-Version: 1.0 References: <1394436721-21812-1-git-send-email-cyliu@suse.com> <1394436721-21812-9-git-send-email-cyliu@suse.com> In-Reply-To: <1394436721-21812-9-git-send-email-cyliu@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="S3fmmUmB2AVSw0loRAStO8s8Tce3JH4l1" Subject: Re: [Qemu-devel] [PATCH v22 08/25] cow.c: replace QEMUOptionParameter with QemuOpts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Dong Xu Wang , stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --S3fmmUmB2AVSw0loRAStO8s8Tce3JH4l1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/10/2014 01:31 AM, Chunyan Liu wrote: > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block/cow.c | 54 ++++++++++++++++++++++++++---------------------------= - > 1 file changed, 26 insertions(+), 28 deletions(-) >=20 > @@ -414,14 +412,14 @@ static BlockDriver bdrv_cow =3D { > .bdrv_probe =3D cow_probe, > .bdrv_open =3D cow_open, > .bdrv_close =3D cow_close, > - .bdrv_create =3D cow_create, > + .bdrv_create2 =3D cow_create, > .bdrv_has_zero_init =3D bdrv_has_zero_init_1, > =20 > .bdrv_read =3D cow_co_read, > .bdrv_write =3D cow_co_write, > .bdrv_co_get_block_status =3D cow_co_get_block_status, > =20 > - .create_options =3D cow_create_options, > + .create_opts =3D &cow_create_opts, Inconsistent alignment of =3D, and inconsistent use of & (it is not neede= d here, '.create_opts =3D cow_create_opts' is just fine). But those are both minor; Reviewed-by: Eric Blake --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --S3fmmUmB2AVSw0loRAStO8s8Tce3JH4l1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTHyufAAoJEKeha0olJ0Nqf7kH+weG79ptsbp+N0xv4LKGaPLH 9+mD77uWG4/9el23Rqohz9PRo7Dj6hshtb4oI9tl0SrSxlpCKdXI3iT6koyQ5RjT vK4LdQRHqaseEpxH71pUQasyPeYT1VYC4OR3DxV7RFSuy5JzHAHx834ddDgg0H7u ojqQJEqt1VkNjC7pntYpViDW82bgnogHUUC43u2EOc0myPQaVi2jrFHiypPl2m8J f2Kf2fiGW2PrhB9/2T1UmoaaupOr3+6IZXoKQqBuftS8KqfxRstm78KV6lxX/dCO XN75Km435VxbzvgCqkZuExPwbh424JGJpuUzZGUCz73kQwq6aQG9IBdvlHr/SZo= =kDCB -----END PGP SIGNATURE----- --S3fmmUmB2AVSw0loRAStO8s8Tce3JH4l1--