From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39844) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNQ0d-0002HG-Rm for qemu-devel@nongnu.org; Tue, 11 Mar 2014 12:58:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNQ0Z-0001xn-1h for qemu-devel@nongnu.org; Tue, 11 Mar 2014 12:58:31 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56347) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNQ0Y-0001vi-NM for qemu-devel@nongnu.org; Tue, 11 Mar 2014 12:58:26 -0400 Message-ID: <531F40AF.6040909@redhat.com> Date: Tue, 11 Mar 2014 10:58:23 -0600 From: Eric Blake MIME-Version: 1.0 References: <1394436721-21812-1-git-send-email-cyliu@suse.com> <1394436721-21812-10-git-send-email-cyliu@suse.com> In-Reply-To: <1394436721-21812-10-git-send-email-cyliu@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="7OiP2xjp5UDX7UkSJVHKHjOXabpPfbO10" Subject: Re: [Qemu-devel] [PATCH v22 09/25] gluster.c: replace QEMUOptionParameter with QemuOpts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Dong Xu Wang , stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --7OiP2xjp5UDX7UkSJVHKHjOXabpPfbO10 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/10/2014 01:31 AM, Chunyan Liu wrote: > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block/gluster.c | 81 ++++++++++++++++++++++++++++++-------------------= -------- > 1 file changed, 42 insertions(+), 39 deletions(-) >=20 > @@ -726,7 +729,7 @@ static BlockDriver bdrv_gluster =3D { > #ifdef CONFIG_GLUSTERFS_ZEROFILL > .bdrv_co_write_zeroes =3D qemu_gluster_co_write_zeroes, > #endif > - .create_options =3D qemu_gluster_create_options, > + .create_opts =3D &qemu_gluster_create_opts, Unnecessary &. Probably true in most of your patches. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --7OiP2xjp5UDX7UkSJVHKHjOXabpPfbO10 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTH0CvAAoJEKeha0olJ0Nq+0QH+wTQ9ZbXspTIE/m+4wFJqTgw mQ31J1TJCOGbyVov4TSnzbFG9I0/Z4vBtRhBtNf/jVqtPVfCgPgS5jvufXLAfYHG 5rft6ESvNKxt7icaXvrvTkp6t199Yt6BGY26dqtfOijg2Y4hM02Yhzk2oh4Gnoxe INQlVuAfbD0giDYEzUyADSERfL6ohpErtTFWz9gJNp3e8vX2w/blx/3gZA6KYmiQ MzkocDXeQ/yIu0ixu0ndBRPg1z6vRXOxMWIW5cwtJP7FDmTJeN4wEK/szjXxJmWQ gVxU8faBfMgO2yiADc990GpXZELkt35l33GuZleA+5S4uxzAtc2qiytixh7/RwA= =8FKr -----END PGP SIGNATURE----- --7OiP2xjp5UDX7UkSJVHKHjOXabpPfbO10--