From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43320) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNQ7r-0005Eb-0V for qemu-devel@nongnu.org; Tue, 11 Mar 2014 13:06:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNQ7m-0005Ws-LC for qemu-devel@nongnu.org; Tue, 11 Mar 2014 13:05:58 -0400 Received: from mx1.redhat.com ([209.132.183.28]:3252) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNQ7m-0005Wf-CX for qemu-devel@nongnu.org; Tue, 11 Mar 2014 13:05:54 -0400 Message-ID: <531F426E.9020500@redhat.com> Date: Tue, 11 Mar 2014 11:05:50 -0600 From: Eric Blake MIME-Version: 1.0 References: <1394436721-21812-1-git-send-email-cyliu@suse.com> <1394436721-21812-12-git-send-email-cyliu@suse.com> In-Reply-To: <1394436721-21812-12-git-send-email-cyliu@suse.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="GmN83teguLRIH1T98mPoJkcPwhcR1aKVc" Subject: Re: [Qemu-devel] [PATCH v22 11/25] qcow.c: replace QEMUOptionParameter with QemuOpts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chunyan Liu , qemu-devel@nongnu.org Cc: kwolf@redhat.com, Dong Xu Wang , stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --GmN83teguLRIH1T98mPoJkcPwhcR1aKVc Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/10/2014 01:31 AM, Chunyan Liu wrote: > Signed-off-by: Dong Xu Wang > Signed-off-by: Chunyan Liu > --- > block/qcow.c | 72 ++++++++++++++++++++++++++++++----------------------= -------- > 1 file changed, 36 insertions(+), 36 deletions(-) See my comments on patch 24 - this commit temporarily breaks the vvfat driver, which is trying to reuse the qcow create_options member. > @@ -920,7 +920,7 @@ static BlockDriver bdrv_qcow =3D { > .bdrv_write_compressed =3D qcow_write_compressed, > .bdrv_get_info =3D qcow_get_info, > =20 > - .create_options =3D qcow_create_options, > + .create_opts =3D &qcow_create_opts, > }; > =20 > static void bdrv_qcow_init(void) >=20 --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --GmN83teguLRIH1T98mPoJkcPwhcR1aKVc Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTH0JuAAoJEKeha0olJ0NqaXcIAIpawFHlI2Z1srQtyltgMxyJ 1p576g08ipO16vQxZp+7olnVKDVfGdS6pZ1JFW7MZ2e4rrKKo6JtHxbXMrYnkbV+ 7v9sMjGCH0jsG9KE0HrW+z4wm6q2yVi7YErjeOwkXGkz6qUxKfGg2AkgL9pyEjug Jr2RTZaFbZbraVTYC+yTw53f1RQz+mAPPnjRX/hTZdlFskMRrb2aSYDFK+WF6z7w 9YH1spARESZ8Uau3JVar/sVv0nt0pz27yw7W0thqe3xb9V2FcHgACBSySvmjnOjp LFghKWMCacaBnd98a3d0PDxSdMeny2JdTuhYp0U9sqZQHUWvy82BThQmn1EEUQo= =3qy4 -----END PGP SIGNATURE----- --GmN83teguLRIH1T98mPoJkcPwhcR1aKVc--