From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45867) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNQDj-0000qa-73 for qemu-devel@nongnu.org; Tue, 11 Mar 2014 13:12:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNQDd-00081b-7o for qemu-devel@nongnu.org; Tue, 11 Mar 2014 13:12:03 -0400 Received: from cantor2.suse.de ([195.135.220.15]:50751 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNQDd-00081H-1b for qemu-devel@nongnu.org; Tue, 11 Mar 2014 13:11:57 -0400 Message-ID: <531F43DB.4030405@suse.de> Date: Tue, 11 Mar 2014 18:11:55 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1394552156-18901-1-git-send-email-marcel.a@redhat.com> In-Reply-To: <1394552156-18901-1-git-send-email-marcel.a@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 0/3] tests/qdev-global-props: fixes due to machine conversion to QOM List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcel Apfelbaum , qemu-devel@nongnu.org Cc: kwolf@redhat.com, ehabkost@redhat.com, mst@redhat.com, stefanha@redhat.com, armbru@redhat.com, aliguori@amazon.com, pbonzini@redhat.com, lersek@redhat.com Hi Marcel, Am 11.03.2014 16:35, schrieb Marcel Apfelbaum: > To be applied on top of: > hw/boards: converted current_machine to be an instance of MachineCl= ass > Rebased for qom-next branch of Andrea's QOM tree. >=20 > Patch 1: allows to assign QEMUMachine "automatically", > and not only in vl.c (we need this in tests) > Patch 2: converts "none-machine" to QOM > Patch 3: Fixes qdev-global-props by adding the "none-machine" > to the tree. >=20 > Cc: Andreas F=C3=A4rber >=20 > Marcel Apfelbaum (3): > hw/machine: move QEMUMachine assignment into the core machine > hw/null-machine: Convert null machine to QOM > tests/qdev-global-props: Manually add an instance of a QOM machine It seems I am to blame for most of the problems you are working around now, so let's not be too shy to correct myself and make things easier on us. ;) I'd rather not take the class_base_init patch - for one class_init would be more correct, but for another I generally don't like putting such requirements onto use of a base class. The null machine seems indeed low hanging fruit for further cleanups - but can't we start by making MachineClass used instead of QEMUMachine? Then we won't need to assign mc->qemu_machine any more and can start dropping machine_none. Regards, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg