From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:41133)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WNRQy-0006yG-Kv
	for qemu-devel@nongnu.org; Tue, 11 Mar 2014 14:29:54 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WNRQq-0004kQ-1G
	for qemu-devel@nongnu.org; Tue, 11 Mar 2014 14:29:48 -0400
Received: from cantor2.suse.de ([195.135.220.15]:51973 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1WNRQp-0004kL-RZ
	for qemu-devel@nongnu.org; Tue, 11 Mar 2014 14:29:39 -0400
Message-ID: <531F5613.8070601@suse.de>
Date: Tue, 11 Mar 2014 19:29:39 +0100
From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1393842608-17795-1-git-send-email-stefanha@redhat.com>
	<1393842608-17795-6-git-send-email-stefanha@redhat.com>
In-Reply-To: <1393842608-17795-6-git-send-email-stefanha@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v6 5/7] qdev: make get_pointer() handle
 temporary strings
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Stefan Hajnoczi <stefanha@redhat.com>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>, Fam Zheng <famz@redhat.com>, "Shergill,
	Gurinder" <gurinder.shergill@hp.com>, Michael Roth <mdroth@linux.vnet.ibm.com>, Paolo Bonzini <pbonzini@redhat.com>, "Vinod, Chegu" <chegu_vinod@hp.com>

Am 03.03.2014 11:30, schrieb Stefan Hajnoczi:
> From: Igor Mammedov <imammedo@redhat.com>
>=20
> get_pointer()'s print() callback might return a heap allocated
> string, to avoid adding dedicated get_pointer_foo for this case
> convert current print() callbacks to return temporary heap
> allocated string and make get_pointer() free it.
>=20
> Cc: "Andreas F=C3=A4rber" <afaerber@suse.de>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>

v5 got my

Reviewed-by: Andreas F=C3=A4rber <afaerber@suse.de>

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC=
rnberg