From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41704) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNRTU-0000yt-6f for qemu-devel@nongnu.org; Tue, 11 Mar 2014 14:32:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNRTL-0005Tv-JL for qemu-devel@nongnu.org; Tue, 11 Mar 2014 14:32:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59411) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNRTL-0005TC-C7 for qemu-devel@nongnu.org; Tue, 11 Mar 2014 14:32:15 -0400 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2BIWC9t000565 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 11 Mar 2014 14:32:12 -0400 Message-ID: <531F56A8.30705@redhat.com> Date: Tue, 11 Mar 2014 19:32:08 +0100 From: Max Reitz MIME-Version: 1.0 References: <1394556161-16030-1-git-send-email-kwolf@redhat.com> In-Reply-To: <1394556161-16030-1-git-send-email-kwolf@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qcow2: Keep option in qcow2_invalidate_cache() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf , qemu-devel@nongnu.org Cc: stefanha@redhat.com On 11.03.2014 17:42, Kevin Wolf wrote: > Instead of manually building a list of all options from BDRVQcowState > values just reuse the options that were used to open the image. > qcow2_open() won't fully use all of the options in the QDict, but that's > okay. > > This fixes all of the driver-specific options in qcow2, except for > lazy-refcounts, which was special cased before. > > Signed-off-by: Kevin Wolf > --- > block/qcow2.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) Reviewed-by: Max Reitz