From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNTi5-0001Yd-Sc for qemu-devel@nongnu.org; Tue, 11 Mar 2014 16:55:42 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNTi1-0006uq-HU for qemu-devel@nongnu.org; Tue, 11 Mar 2014 16:55:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:5932) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNTi1-0006ue-8i for qemu-devel@nongnu.org; Tue, 11 Mar 2014 16:55:33 -0400 Message-ID: <531F7836.3030302@redhat.com> Date: Tue, 11 Mar 2014 14:55:18 -0600 From: Eric Blake MIME-Version: 1.0 References: <1394542415-5152-1-git-send-email-arei.gonglei@huawei.com> <1394542415-5152-6-git-send-email-arei.gonglei@huawei.com> <87fvmo31ic.fsf@elfo.mitica> In-Reply-To: <87fvmo31ic.fsf@elfo.mitica> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="T2u1JQNtmS4DOL0WQ8PtGbMT0jPxQBNFi" Subject: Re: [Qemu-devel] [PATCH 05/10] migration: Fix the migrate auto converge process List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: quintela@redhat.com, arei.gonglei@huawei.com Cc: ChenLiang , weidong.huang@huawei.com, qemu-devel@nongnu.org, owasserm@redhat.com, pbonzini@redhat.com, chegu_vinod@hp.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --T2u1JQNtmS4DOL0WQ8PtGbMT0jPxQBNFi Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/11/2014 02:48 PM, Juan Quintela wrote: > wrote: >> From: ChenLiang >> >> It is inaccuracy and complex that using the transfer speed of >> migration thread to determine whether the convergence migration. >> The dirty page may be compressed by XBZRLE or ZERO_PAGE.The counter >> of updating dirty bitmap will be increasing continuously if the >> migration can't convergence. >=20 > "It is inexact and complex to use the migration transfer speed to > dectermine weather the convergence of migration." or even better (plus spelling fixes): determine whether migration is converging >=20 >> @@ -530,21 +523,11 @@ static void migration_bitmap_sync(void) >> /* more than 1 second =3D 1000 millisecons */ Pre-existing, but as long as you are touching this area of code: s/millisecons/milliseconds/ --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --T2u1JQNtmS4DOL0WQ8PtGbMT0jPxQBNFi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTH3g2AAoJEKeha0olJ0Nqe8gH/1Qwx/7ZORhxIOUz3sBsXSQx lI0Lqq/7Ajx6oxQtEuz3Dh9aacQqlkFK26yVW1wk5uX+L2KXrYJB1xREVqdWAM2T cjepdcAGxbHjktj1o91bEd2cUPrnHLHsfpxNS1JVwEh5CJJZDUWeoV4saXTdbbyp SUI6h8nGTiI1KS0Vn/6xFXoN08skAul782hRY1xW/jSuv8NPGz7hA+7eoUM4kon0 V1tfID2LocQC3AnAxQqF04fV1B49/R96EX42pOH8fYNuWiGCc3KLpoJHmObMuDF3 6VDRAoZSHwjku9jZpLrXuB231fWUghv6OJ0IfzygUj5SABhTB7AzhH7VJAr3bUw= =aYCd -----END PGP SIGNATURE----- --T2u1JQNtmS4DOL0WQ8PtGbMT0jPxQBNFi--