From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53854) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNTp0-0001Hc-Us for qemu-devel@nongnu.org; Tue, 11 Mar 2014 17:02:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNTow-0000vE-Jz for qemu-devel@nongnu.org; Tue, 11 Mar 2014 17:02:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34987) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNTow-0000uz-BQ for qemu-devel@nongnu.org; Tue, 11 Mar 2014 17:02:42 -0400 Message-ID: <531F79E0.6080607@redhat.com> Date: Tue, 11 Mar 2014 15:02:24 -0600 From: Eric Blake MIME-Version: 1.0 References: <1394542415-5152-1-git-send-email-arei.gonglei@huawei.com> <1394542415-5152-9-git-send-email-arei.gonglei@huawei.com> In-Reply-To: <1394542415-5152-9-git-send-email-arei.gonglei@huawei.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="N4DSXhUQN943J6OJo4iMRKj6OQas4IHiQ" Subject: Re: [Qemu-devel] [PATCH 08/10] migration: s/uint64_t/int64_t the definitions of it_age List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: arei.gonglei@huawei.com, qemu-devel@nongnu.org Cc: ChenLiang , owasserm@redhat.com, pbonzini@redhat.com, weidong.huang@huawei.com, quintela@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --N4DSXhUQN943J6OJo4iMRKj6OQas4IHiQ Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/11/2014 06:53 AM, arei.gonglei@huawei.com wrote: > From: ChenLiang >=20 The subject line says what, but there is no WHY. The commit message should explain why you want a signed type. > Signed-off-by: ChenLiang > Signed-off-by: Gonglei > --- > arch_init.c | 4 ++-- > include/migration/page_cache.h | 4 ++-- > page_cache.c | 6 +++--- > 3 files changed, 7 insertions(+), 7 deletions(-) >=20 > diff --git a/arch_init.c b/arch_init.c > index 461a10a..1c1488a 100644 > --- a/arch_init.c > +++ b/arch_init.c > @@ -109,7 +109,7 @@ const uint32_t arch_type =3D QEMU_ARCH; > static bool mig_throttle_on; > static void check_guest_throttling(void); > =20 > -static uint64_t bitmap_sync_cnt; > +static int64_t bitmap_sync_cnt; Wait. Patch 2/10 introduced this variable. Why not introduce it with the correct type to begin with? Please reorder your series so that you aren't churning on new code. > -static inline uint64_t get_bitmap_sync_cnt(void) > +static inline int64_t get_bitmap_sync_cnt(void) > { > return bitmap_sync_cnt; Not to mention that my argument in patch 2 still holds - unless you are going to export this function, it is pointless compared to just using the variable directly. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --N4DSXhUQN943J6OJo4iMRKj6OQas4IHiQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTH3ngAAoJEKeha0olJ0NqZXYH/R62yylM112zJpBaMMyLDVRF RAzbL1UwrKIxGHfx7D3iX+keEvFx8qV/btOqtQmsMNpgeAyqolayETxH3oBfbLXm 6mLEXzN0AJ59XSihQe/aCkbJWGoPDN2MgThIFcX0rWo+KhPOPIKLw/MzYte5ctnE ERtxY261GCj4jA1muX2wAMDrMPaiYXVXBYcRXr5OzIhMdhDGFhl21udXl+VeT78C /Y5M1oKnRarhI+HTph8OENrw6VdrziySqjF76L8TQBAeiYYCqFIu1PGRRdI4xwsr hX4I+xK6v25uT1Rq1dlfIQra4abQvxyxF4KZPBqxdtmA1p6STwORkkx3Jkr4Cp8= =hoIj -----END PGP SIGNATURE----- --N4DSXhUQN943J6OJo4iMRKj6OQas4IHiQ--