From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34956) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNUPn-0006ce-5m for qemu-devel@nongnu.org; Tue, 11 Mar 2014 17:40:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNUPi-0005ib-8K for qemu-devel@nongnu.org; Tue, 11 Mar 2014 17:40:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27326) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNUPh-0005iT-Ux for qemu-devel@nongnu.org; Tue, 11 Mar 2014 17:40:42 -0400 Message-ID: <531F82CA.8070905@redhat.com> Date: Tue, 11 Mar 2014 15:40:26 -0600 From: Eric Blake MIME-Version: 1.0 References: <1392713429-18201-1-git-send-email-mrhines@linux.vnet.ibm.com> <1392713429-18201-4-git-send-email-mrhines@linux.vnet.ibm.com> In-Reply-To: <1392713429-18201-4-git-send-email-mrhines@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Sd59dPvGWpP1tNkd93P604Cfljprwm760" Subject: Re: [Qemu-devel] [RFC PATCH v2 03/12] mc: introduce a 'checkpointing' status check into the VCPU states List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrhines@linux.vnet.ibm.com, qemu-devel@nongnu.org Cc: GILR@il.ibm.com, SADEKJ@il.ibm.com, quintela@redhat.com, BIRAN@il.ibm.com, hinesmr@cn.ibm.com, EREZH@il.ibm.com, owasserm@redhat.com, onom@us.ibm.com, junqing.wang@cs2c.com.cn, lig.fnst@cn.fujitsu.com, gokul@us.ibm.com, dbulkow@gmail.com, pbonzini@redhat.com, abali@us.ibm.com, isaku.yamahata@gmail.com, "Michael R. Hines" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Sd59dPvGWpP1tNkd93P604Cfljprwm760 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/18/2014 01:50 AM, mrhines@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" >=20 > During micro-checkpointing, the VCPUs get repeatedly paused and > resumed. We need to not freak out when the VM begins micro-checkpointin= g. >=20 > Signed-off-by: Michael R. Hines > --- > cpus.c | 9 ++++++++- > include/migration/migration.h | 21 +++++++++++++++++++++ > qapi-schema.json | 4 +++- > vl.c | 7 +++++++ > 4 files changed, 39 insertions(+), 2 deletions(-) >=20 > +++ b/qapi-schema.json > @@ -169,6 +169,8 @@ > # > # @save-vm: guest is paused to save the VM state > # > +# @checkpoint-vm: guest is paused to checkpoint the VM state > +# It would be nice to mention '(since 2.1)'. > # @shutdown: guest is shut down (and -no-shutdown is in use) > # > # @suspended: guest is suspended (ACPI S3) > @@ -181,7 +183,7 @@ > 'data': [ 'debug', 'inmigrate', 'internal-error', 'io-error', 'pause= d', > 'postmigrate', 'prelaunch', 'finish-migrate', 'restore-vm'= , > 'running', 'save-vm', 'shutdown', 'suspended', 'watchdog',= > - 'guest-panicked' ] } > + 'guest-panicked', 'checkpoint-vm' ] } It would also be nice to document the enum variables in the same order you declare them. The declaration of 'checkpoint-vm' does not have to be at the end; we use named enums precisely so that the QMP interface is not tied to the C integer value underlying the enum. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --Sd59dPvGWpP1tNkd93P604Cfljprwm760 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTH4LKAAoJEKeha0olJ0NqZDcH/3SsD8zePFjSaMjJSHj2X/Ku ciL6zWjazeW9WEnw9XINdn8KdvdiKFswYeQxwiWsQildEq96Lwaxjm9lEptVq70S MHCQXojiu52WA8ynmnWcrKS1AwFO8WrFtIJJ7gY9Dc1rQzeFVzPqTS4FDucUO4s2 W1DLL1eNdNPRbafPjTf3RsCClHcZ9pFhA9E+JEo1p3EqGTy1aWFw9zO22vR7947j CGodid1kcABM9wZZzsI/syrnyZ9ct74Fs+eUBIw2S35B15x+D7hiOFfpp7LM8LVG zyW81R4xqkFNRV/M9T5mqL6z3uZZfOsCUGHace6CVLv+6KrOALgKegtIGMSfkUI= =vDDl -----END PGP SIGNATURE----- --Sd59dPvGWpP1tNkd93P604Cfljprwm760--