From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:35969) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNUUa-0000t9-P8 for qemu-devel@nongnu.org; Tue, 11 Mar 2014 17:45:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNUUV-0007Dq-T3 for qemu-devel@nongnu.org; Tue, 11 Mar 2014 17:45:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:29279) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNUUV-0007Dl-FW for qemu-devel@nongnu.org; Tue, 11 Mar 2014 17:45:39 -0400 Message-ID: <531F83E3.5050803@redhat.com> Date: Tue, 11 Mar 2014 15:45:07 -0600 From: Eric Blake MIME-Version: 1.0 References: <1392713429-18201-1-git-send-email-mrhines@linux.vnet.ibm.com> <1392713429-18201-8-git-send-email-mrhines@linux.vnet.ibm.com> In-Reply-To: <1392713429-18201-8-git-send-email-mrhines@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="hwvNUkoOq9IL7FIrFiKCwhBJChHwn9t7H" Subject: Re: [Qemu-devel] [RFC PATCH v2 07/12] mc: introduce additional QMP statistics for micro-checkpointing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrhines@linux.vnet.ibm.com, qemu-devel@nongnu.org Cc: GILR@il.ibm.com, SADEKJ@il.ibm.com, quintela@redhat.com, BIRAN@il.ibm.com, hinesmr@cn.ibm.com, EREZH@il.ibm.com, owasserm@redhat.com, onom@us.ibm.com, junqing.wang@cs2c.com.cn, lig.fnst@cn.fujitsu.com, gokul@us.ibm.com, dbulkow@gmail.com, pbonzini@redhat.com, abali@us.ibm.com, isaku.yamahata@gmail.com, "Michael R. Hines" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --hwvNUkoOq9IL7FIrFiKCwhBJChHwn9t7H Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/18/2014 01:50 AM, mrhines@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" >=20 > MC provides a lot of new information, including the same RAM statistics= > that ordinary migration does, so we centralize a lot of that printing > code into a common function so that the QMP printing statements don't > get duplicated too much. >=20 > We also introduce a new MCStats structure (like MigrationStats) due > to the large number of non-migration related statistics - don't want > to confuse migration and MC too much, so let's keep them separate for n= ow. >=20 > Signed-off-by: Michael R. Hines > --- > +++ b/qapi-schema.json > @@ -603,6 +603,36 @@ > 'cache-miss': 'int', 'overflow': 'int' } } > =20 > ## > +# @MCStats > +# > +# Detailed Micro Checkpointing (MC) statistics > +# > +# @mbps: throughput of transmitting last MC=20 > +# > +# @xmit-time: milliseconds to transmit last MC=20 Trailing whitespace. Rather than abbreviate, how about naming this 'transmit-time'. > +# > +# @checkpoints: cummulative total number of MCs generated=20 More trailing whitespace. Please run your series through scripts/checkpatch.pl. s/cummulative total/cumulative/ > +# > +# Since: 2.x > +## > +{ 'type': 'MCStats', > + 'data': {'mbps': 'number', > + 'xmit-time': 'uint64', > + 'log-dirty-time': 'uint64', > + 'migration-bitmap-time': 'uint64',=20 > + 'ram-copy-time': 'uint64', > + 'checkpoints' : 'uint64', > + 'copy-mbps': 'number' }} Again, it helps to document the fields in the same order as they are declared (no, it's not a hard requirement, but being nice to readers is always worth the effort). > + > +## > # @MigrationInfo > # > # Information about current migration process. > @@ -624,6 +654,8 @@ > # migration statistics, only returned if XBZRLE feature= is on and > # status is 'active' or 'completed' (since 1.2) > # > +# @mc: #options @MCStats containing details Micro-Checkpointing statis= tics s/options/optional/ - I'm assuming it is optional because it only appears when MC is in use. 'mc' is a rather short name, maybe 'micro-checkpoint' is better? Missing a '(since 2.1)' designation (or 2.x, as you used above as a placeholder, although obviously we'd fix the .x before actually bringing into mainline) --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --hwvNUkoOq9IL7FIrFiKCwhBJChHwn9t7H Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTH4PjAAoJEKeha0olJ0NqJ/EH/2oG2yxF2zNOUB6Mt3ZOYDmo b6sSrMjii+kd5whbaRZHUp88d31OjDDtQy2h8lullr4QtNeoqWZX14EDwzABr3W6 eWy4VxWnLxp4c3ngwhShJDgaaNXRdUfU8cXHJzR9ngkhLrKof1OXyv+qYGEy7gay uHQofUXto9mNwDF4Hn4ytzv1Ym2ObWeRzJCj9BSyWctZyWi5nolKaowCItrNsU2E 7hYBoP/mWGHcwAnpbJRxF8iRVcoeI9pKNSvfQWfTNYxq/cg7J5rG7tFIRdIGTwZb CchzBsyrQuIJG+4PBMPom4CmUIojaLDd+L7+8s/mJ91A15fynm+annV4M+crWR4= =xvhM -----END PGP SIGNATURE----- --hwvNUkoOq9IL7FIrFiKCwhBJChHwn9t7H--