From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:36627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNUZ2-0003E8-5x for qemu-devel@nongnu.org; Tue, 11 Mar 2014 17:50:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNUYx-0000Gs-6Q for qemu-devel@nongnu.org; Tue, 11 Mar 2014 17:50:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:20386) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNUYw-0000GF-U3 for qemu-devel@nongnu.org; Tue, 11 Mar 2014 17:50:15 -0400 Message-ID: <531F84FD.7010608@redhat.com> Date: Tue, 11 Mar 2014 15:49:49 -0600 From: Eric Blake MIME-Version: 1.0 References: <1392713429-18201-1-git-send-email-mrhines@linux.vnet.ibm.com> <1392713429-18201-11-git-send-email-mrhines@linux.vnet.ibm.com> In-Reply-To: <1392713429-18201-11-git-send-email-mrhines@linux.vnet.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cvveddWPduvJLXFHD29gNJImw3VpX6TP9" Subject: Re: [Qemu-devel] [RFC PATCH v2 10/12] mc: expose tunable parameter for checkpointing frequency List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mrhines@linux.vnet.ibm.com, qemu-devel@nongnu.org Cc: GILR@il.ibm.com, SADEKJ@il.ibm.com, quintela@redhat.com, BIRAN@il.ibm.com, hinesmr@cn.ibm.com, EREZH@il.ibm.com, owasserm@redhat.com, onom@us.ibm.com, junqing.wang@cs2c.com.cn, lig.fnst@cn.fujitsu.com, gokul@us.ibm.com, dbulkow@gmail.com, pbonzini@redhat.com, abali@us.ibm.com, isaku.yamahata@gmail.com, "Michael R. Hines" This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --cvveddWPduvJLXFHD29gNJImw3VpX6TP9 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 02/18/2014 01:50 AM, mrhines@linux.vnet.ibm.com wrote: > From: "Michael R. Hines" >=20 > This exposes a QMP command that allows the management software > or policy to control the frequency of micro-checkpointing. >=20 > Signed-off-by: Michael R. Hines > --- > hmp-commands.hx | 16 +++++++++++++++- > hmp.c | 6 ++++++ > hmp.h | 1 + > qapi-schema.json | 13 +++++++++++++ > qmp-commands.hx | 23 +++++++++++++++++++++++ > 5 files changed, 58 insertions(+), 1 deletion(-) >=20 > diff --git a/hmp-commands.hx b/hmp-commands.hx > index f3fc514..2066c76 100644 > --- a/hmp-commands.hx > +++ b/hmp-commands.hx > @@ -888,7 +888,7 @@ ETEXI > "\n\t\t\t -b for migration without shared storage with" > " full copy of disk\n\t\t\t -i for migration without " > "shared storage with incremental copy of disk " > - "(base image shared between src and destination)", > + "(base image shared between src and destination)", Spurious hunk. Oh, I see - you managed to take TAB damage and make it worse with a space-TAB (I guess this file isn't tab-clean, like the =2Ejson file is). Eww. > .mhandler.cmd =3D hmp_migrate, > }, > =20 > @@ -965,6 +965,20 @@ Set maximum tolerated downtime (in seconds) for mi= gration. > ETEXI > =20 > { > + .name =3D "migrate-set-mc-delay", We're building up a LOT of migrate- tunable commands. Maybe it's time to think about building a more generic migrate-set-parameter, which takes both the name of the parameter to set and its value, so that a single command serves all parameters, instead of needing a proliferation of commands. Of course, for that to be useful, we also need a way to introspect which parameters can be tuned; whereas with the current approach of one command per parameter (well, 2 for set vs. get) the introspection is based on whether the command exists. > +++ b/qapi-schema.json > @@ -2160,6 +2160,19 @@ > { 'command': 'migrate_set_downtime', 'data': {'value': 'number'} } > =20 > ## > +# @migrate-set-mc-delay > +# > +# Set delay (in milliseconds) between micro checkpoints. > +# > +# @value: maximum delay in milliseconds=20 > +# > +# Returns: nothing on success > +# > +# Since: 2.x > +## > +{ 'command': 'migrate-set-mc-delay', 'data': {'value': 'int'} } > + > +## I hate write-only interfaces. If I can set the parameter, I _also_ need a way to query the current value of the parameter. Either an existing migration statistics output should be modified to include this new information, or you need to add a counterpart migrate-get-mc-delay comman= d. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --cvveddWPduvJLXFHD29gNJImw3VpX6TP9 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTH4T9AAoJEKeha0olJ0NqYY8H/26OOwQ3v0q0I+je7BvLoJP6 qy3DkBpdpE1z1JT+JRJJ8DjAJOwy7XyOmWRkzeYnBKU+X3gYThnkDkldbuNtO7qx G2QPlIGZr2Im+ftY8uHyvc5dFCMF4jedyeV0jbG5tkkmfQ8jLqsPRE5Fz163K0HS 9L3xCmkfOEkjNyHAG8GYhk+luvFPJkcAWTDL8tdiFMqT6nzfBJDeVP88r02ZtKVI 62FlzTqbKukzezsUXryBUyKrtZpYAx0rwkWfkfB/Qbjl/HAFDQf7keDuoInwSVHf AtrvM64/1ty/DQdUp4j73XOxD1oFXTsrWf72Eq/7oFQzvnuXURGrT+0ENl3zpUU= =1U8C -----END PGP SIGNATURE----- --cvveddWPduvJLXFHD29gNJImw3VpX6TP9--