From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 186E1C0044D for ; Mon, 16 Mar 2020 19:01:08 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFD9020663 for ; Mon, 16 Mar 2020 19:01:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DFD9020663 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kaod.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46954 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDuz5-0001uh-42 for qemu-devel@archiver.kernel.org; Mon, 16 Mar 2020 15:01:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58805) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDu2w-0004HJ-UZ for qemu-devel@nongnu.org; Mon, 16 Mar 2020 14:01:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDu2v-00077p-P4 for qemu-devel@nongnu.org; Mon, 16 Mar 2020 14:01:02 -0400 Received: from 5.mo1.mail-out.ovh.net ([178.33.45.107]:58864) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jDu2v-0006zV-H4 for qemu-devel@nongnu.org; Mon, 16 Mar 2020 14:01:01 -0400 Received: from player716.ha.ovh.net (unknown [10.110.208.183]) by mo1.mail-out.ovh.net (Postfix) with ESMTP id BB8CD1B564F for ; Mon, 16 Mar 2020 19:00:59 +0100 (CET) Received: from kaod.org (82-64-250-170.subs.proxad.net [82.64.250.170]) (Authenticated sender: clg@kaod.org) by player716.ha.ovh.net (Postfix) with ESMTPSA id 2C48B1069AEFC; Mon, 16 Mar 2020 18:00:47 +0000 (UTC) Subject: Re: [PATCH v2 5/8] ppc/spapr: Allow FWNMI on TCG To: Nicholas Piggin , qemu-ppc@nongnu.org References: <20200316142613.121089-1-npiggin@gmail.com> <20200316142613.121089-6-npiggin@gmail.com> From: =?UTF-8?Q?C=c3=a9dric_Le_Goater?= Message-ID: <531bdcf7-e54a-4fe4-ff78-7d8bc5ef1e7c@kaod.org> Date: Mon, 16 Mar 2020 19:00:46 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 MIME-Version: 1.0 In-Reply-To: <20200316142613.121089-6-npiggin@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Ovh-Tracer-Id: 13752585887778507750 X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedugedrudeffedguddtjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfqggfjpdevjffgvefmvefgnecuuegrihhlohhuthemucehtddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefuvfhfhffkffgfgggjtgfgsehtkeertddtfeejnecuhfhrohhmpeevrogurhhitggpnfgvpgfiohgrthgvrhcuoegtlhhgsehkrghougdrohhrgheqnecukfhppedtrddtrddtrddtpdekvddrieegrddvhedtrddujedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmohguvgepshhmthhpqdhouhhtpdhhvghlohepphhlrgihvghrjeduiedrhhgrrdhovhhhrdhnvghtpdhinhgvtheptddrtddrtddrtddpmhgrihhlfhhrohhmpegtlhhgsehkrghougdrohhrghdprhgtphhtthhopehqvghmuhdquggvvhgvlhesnhhonhhgnhhurdhorhhg Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 178.33.45.107 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Aravinda Prasad , David Gibson , Ganesh Goudar , qemu-devel@nongnu.org, Greg Kurz Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 3/16/20 3:26 PM, Nicholas Piggin wrote: > There should no longer be a reason to prevent TCG providing FWNMI. > System Reset interrupts are generated to the guest with nmi monitor > command and H_SIGNAL_SYS_RESET. Machine Checks can not be injected > currently, but this could be implemented with the mce monitor cmd > similarly to i386. >=20 > Signed-off-by: Nicholas Piggin Reviewed-by: C=C3=A9dric Le Goater > --- > hw/ppc/spapr_caps.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) >=20 > diff --git a/hw/ppc/spapr_caps.c b/hw/ppc/spapr_caps.c > index f626d769a0..679ae7959f 100644 > --- a/hw/ppc/spapr_caps.c > +++ b/hw/ppc/spapr_caps.c > @@ -516,10 +516,7 @@ static void cap_fwnmi_apply(SpaprMachineState *spa= pr, uint8_t val, > return; /* Disabled by default */ > } > =20 > - if (tcg_enabled()) { > - warn_report("Firmware Assisted Non-Maskable Interrupts(FWNMI) = not " > - "supported in TCG"); > - } else if (kvm_enabled()) { > + if (kvm_enabled()) { > if (kvmppc_set_fwnmi() < 0) { > error_setg(errp, "Firmware Assisted Non-Maskable Interrupt= s(FWNMI) " > "not supported by KVM"); >=20