Re: [PATCH v2 1/7] migration/multifd: Add new migration option zero-page-detection.

["Wang, Lei" <lei4.wang@intel.com>]

On 2/17/2024 6:39, Hao Xiang wrote:
> This new parameter controls where the zero page checking is running.
> 1. If this parameter is set to 'legacy', zero page checking is
> done in the migration main thread.
> 2. If this parameter is set to 'none', zero page checking is disabled.
> 
> Signed-off-by: Hao Xiang <hao.xiang@bytedance.com>
> ---
>  hw/core/qdev-properties-system.c    | 10 ++++++++++
>  include/hw/qdev-properties-system.h |  4 ++++
>  migration/migration-hmp-cmds.c      |  9 +++++++++
>  migration/options.c                 | 21 ++++++++++++++++++++
>  migration/options.h                 |  1 +
>  migration/ram.c                     |  4 ++++
>  qapi/migration.json                 | 30 ++++++++++++++++++++++++++---
>  7 files changed, 76 insertions(+), 3 deletions(-)
> 
> diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c
> index 1a396521d5..63843f18b5 100644
> --- a/hw/core/qdev-properties-system.c
> +++ b/hw/core/qdev-properties-system.c
> @@ -679,6 +679,16 @@ const PropertyInfo qdev_prop_mig_mode = {
>      .set_default_value = qdev_propinfo_set_default_value_enum,
>  };
>  
> +const PropertyInfo qdev_prop_zero_page_detection = {
> +    .name = "ZeroPageDetection",
> +    .description = "zero_page_detection values, "
> +                   "multifd,legacy,none",

Nit: Maybe multifd/legacy/none?