From: Richard Henderson <rth@twiddle.net>
To: "Peter Maydell" <peter.maydell@linaro.org>,
"Alex Bennée" <alex.bennee@linaro.org>
Cc: QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [RCF PATCH 1/2] tcg: add tcg_abort_dbg() for additional debug info
Date: Wed, 12 Mar 2014 08:05:04 -0700 [thread overview]
Message-ID: <532077A0.80908@twiddle.net> (raw)
In-Reply-To: <CAFEAcA-CA+x8wUL7nxomDaox1OKnaakwbi6ieR=0uVq2bnNMLA@mail.gmail.com>
On 03/12/2014 08:02 AM, Peter Maydell wrote:
> This is the wrong place to be diagnosing this. We should be (when
> TCG debug is enabled) checking the condition when the tcg_gen_setcond
> or tcg_set_brcond function is called, so that you get a useful backtrace
> that points directly at the buggy frontend code. I suspect the other
> two cases are similar.
Indeed. See the asserts in tcg_gen_deposit_i32 for example.
r~
next prev parent reply other threads:[~2014-03-12 15:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-12 14:12 [Qemu-devel] [RCF PATCH 0/2] Improving TCG debug output alex.bennee
2014-03-12 14:12 ` [Qemu-devel] [RCF PATCH 1/2] tcg: add tcg_abort_dbg() for additional debug info alex.bennee
2014-03-12 15:02 ` Peter Maydell
2014-03-12 15:05 ` Richard Henderson [this message]
2014-03-12 14:12 ` [Qemu-devel] [RCF PATCH 2/2] tcg: add debug helpers tcg_debug_dump_i(32|64) alex.bennee
-- strict thread matches above, loose matches on Subject: below --
2014-03-12 13:49 [Qemu-devel] [RCF PATCH 0/2] Improving TCG debug output alex.bennee
2014-03-12 13:49 ` [Qemu-devel] [RCF PATCH 1/2] tcg: add tcg_abort_dbg() for additional debug info alex.bennee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=532077A0.80908@twiddle.net \
--to=rth@twiddle.net \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).