From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38647)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1WNn0E-0001PW-IX
	for qemu-devel@nongnu.org; Wed, 12 Mar 2014 13:31:45 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1WNn07-0000ca-9Q
	for qemu-devel@nongnu.org; Wed, 12 Mar 2014 13:31:38 -0400
Received: from david.siemens.de ([192.35.17.14]:58982)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@siemens.com>) id 1WNn07-0000cE-0s
	for qemu-devel@nongnu.org; Wed, 12 Mar 2014 13:31:31 -0400
Message-ID: <532099EA.2010905@siemens.com>
Date: Wed, 12 Mar 2014 18:31:22 +0100
From: Jan Kiszka <jan.kiszka@siemens.com>
MIME-Version: 1.0
References: <51E65168.5080907@siemens.com> <51F2BF4F.8030107@siemens.com>
	<5320921E.2080307@suse.de>
In-Reply-To: <5320921E.2080307@suse.de>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 1/2] Add GDB qAttached support
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>
Cc: Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Fabien Chouteau <chouteau@adacore.com>

On 2014-03-12 17:58, Andreas F=E4rber wrote:
> Am 26.07.2013 20:26, schrieb Jan Kiszka:
>> With this patch QEMU handles qAttached request from gdb. When QEMU
>=20
> "With this patch" is always weird to read in Git history, also a
> "gdbstub: " prefix would've been nice for consistency.

Yes, will rephrase this.

>=20
>> replies 1, GDB sends a "detach" command at the end of a debugging
>> session otherwise GDB sends "kill".
>>
>> The default value for qAttached is 1 on system emulation and 0 on user
>> emulation.
>>
>> Based on original version by Fabien Chouteau.
>=20
> If this is based on code by Fabien, shouldn't it carry his Signed-off-b=
y
> before yours?

Need to check how similar our versions actually are, if I can reuse his
signed-off or if I changed it (in that case it's not appropriate to keep
the original signed-off - according to my understanding).

>=20
> Since "GDB stub" is in "Odd Fixes" state, maybe just step up as
> maintainer and send a pull like for SLIRP? :)

Oh, I can surely send a pull, but I can't handle another maintainership
properly. Slirp already became a stepchild...

Thanks for looking into this.

Jan

--=20
Siemens AG, Corporate Technology, CT RTC ITP SES-DE
Corporate Competence Center Embedded Linux