From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50363)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WNncK-0005Y4-O6
	for qemu-devel@nongnu.org; Wed, 12 Mar 2014 14:11:06 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1WNncE-0007dr-Om
	for qemu-devel@nongnu.org; Wed, 12 Mar 2014 14:11:00 -0400
Message-ID: <5320A063.2040501@redhat.com>
Date: Wed, 12 Mar 2014 18:58:59 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1394410549-13751-1-git-send-email-afaerber@suse.de>	<1394410549-13751-10-git-send-email-afaerber@suse.de>
	<531D6F37.2050700@redhat.com> <531FA07B.1040103@suse.de>
In-Reply-To: <531FA07B.1040103@suse.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH qom-cpu v2 09/40] cpu: Turn
 cpu_handle_mmu_fault() into a CPUClass hook
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= <afaerber@suse.de>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>, Jia Liu <proljc@gmail.com>, Anthony Green <green@moxielogic.com>, Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>, Michael Walle <michael@walle.cc>, PowerPC <qemu-ppc@nongnu.org>, "Edgar E. Iglesias" <edgar.iglesias@gmail.com>, Guan Xuetao <gxt@mprc.pku.edu.cn>, Aurelien Jarno <aurelien@aurel32.net>, Richard Henderson <rth@twiddle.net>

Il 12/03/2014 00:47, Andreas F=C3=A4rber ha scritto:
>> > I'm not sure I understand why you omit the hook for *-softmmu.  It
>> > doesn't hurt to have it, does it?
> Actually I wondered the same thing while preparing v2 :) and prepared a=
n
> alternate version, but it did not really help cut down on complexity.

No, I agree it doesn't.  Just in case common non-user-only code will=20
need it in the future.

> The hook is needed for dispatching from common code to target code, and
> that part is user-only. Some targets but not all reuse the user functio=
n
> from softmmu code, others have two different implementations, some don'=
t
> reuse at all. It's a mess.

Ok, that explains it. :)

Paolo