Re: [Qemu-devel] [PATCH qom-next v3 05/15] tests: Add virtio-scsi qtest

[Paolo Bonzini <pbonzini@redhat.com>]

Il 12/03/2014 19:28, Andreas Färber ha scritto:
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  tests/Makefile           |  3 +++
>  tests/virtio-scsi-test.c | 35 +++++++++++++++++++++++++++++++++++
>  2 files changed, 38 insertions(+)
>  create mode 100644 tests/virtio-scsi-test.c
>
> diff --git a/tests/Makefile b/tests/Makefile
> index 308a5a2..75b4659 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -78,6 +78,8 @@ check-qtest-virtio-y += tests/virtio-blk-test$(EXESUF)
>  gcov-files-virtio-y += i386-softmmu/hw/block/virtio-blk.c
>  check-qtest-virtio-y += tests/virtio-rng-test$(EXESUF)
>  gcov-files-virtio-y += hw/virtio/virtio-rng.c
> +check-qtest-virtio-y += tests/virtio-scsi-test$(EXESUF)
> +gcov-files-virtio-y += i386-softmmu/hw/scsi/virtio-scsi.c
>
>  check-qtest-pci-y += tests/e1000-test$(EXESUF)
>  gcov-files-pci-y += hw/net/e1000.c
> @@ -249,6 +251,7 @@ tests/virtio-balloon-test$(EXESUF): tests/virtio-balloon-test.o
>  tests/virtio-blk-test$(EXESUF): tests/virtio-blk-test.o
>  tests/virtio-net-test$(EXESUF): tests/virtio-net-test.o
>  tests/virtio-rng-test$(EXESUF): tests/virtio-rng-test.o
> +tests/virtio-scsi-test$(EXESUF): tests/virtio-scsi-test.o
>  tests/tpci200-test$(EXESUF): tests/tpci200-test.o
>  tests/ipoctal232-test$(EXESUF): tests/ipoctal232-test.o
>  tests/qom-test$(EXESUF): tests/qom-test.o
> diff --git a/tests/virtio-scsi-test.c b/tests/virtio-scsi-test.c
> new file mode 100644
> index 0000000..3230908
> --- /dev/null
> +++ b/tests/virtio-scsi-test.c
> @@ -0,0 +1,35 @@
> +/*
> + * QTest testcase for VirtIO SCSI
> + *
> + * Copyright (c) 2014 SUSE LINUX Products GmbH
> + *
> + * This work is licensed under the terms of the GNU GPL, version 2 or later.
> + * See the COPYING file in the top-level directory.
> + */
> +
> +#include <glib.h>
> +#include <string.h>
> +#include "libqtest.h"
> +#include "qemu/osdep.h"
> +
> +/* Tests only initialization so far. TODO: Replace with functional tests */
> +static void pci_nop(void)
> +{
> +}
> +
> +int main(int argc, char **argv)
> +{
> +    int ret;
> +
> +    g_test_init(&argc, &argv, NULL);
> +    qtest_add_func("/virtio/scsi/pci/nop", pci_nop);
> +
> +    qtest_start("-drive id=drv0,if=none,file=/dev/null "
> +                "-device virtio-scsi-pci,id=vscsi0 "
> +                "-device scsi-hd,bus=vscsi0.0,drive=drv0");
> +    ret = g_test_run();
> +
> +    qtest_end();
> +
> +    return ret;
> +}
>

ACK

If we get a summer of code student, we could aim at making these tests 
work on all PCI platforms.

Paolo