From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55949) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNnw1-0006IJ-Iy for qemu-devel@nongnu.org; Wed, 12 Mar 2014 14:31:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNnvw-0007Me-9a for qemu-devel@nongnu.org; Wed, 12 Mar 2014 14:31:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:43963) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNnvw-0007MP-4l for qemu-devel@nongnu.org; Wed, 12 Mar 2014 14:31:16 -0400 Message-ID: <5320A7EE.9040808@redhat.com> Date: Wed, 12 Mar 2014 19:31:10 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1394648907-20096-1-git-send-email-afaerber@suse.de> <1394648907-20096-6-git-send-email-afaerber@suse.de> In-Reply-To: <1394648907-20096-6-git-send-email-afaerber@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH qom-next v3 05/15] tests: Add virtio-scsi qtest List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org Il 12/03/2014 19:28, Andreas F=C3=A4rber ha scritto: > Cc: Paolo Bonzini > Signed-off-by: Andreas F=C3=A4rber > --- > tests/Makefile | 3 +++ > tests/virtio-scsi-test.c | 35 +++++++++++++++++++++++++++++++++++ > 2 files changed, 38 insertions(+) > create mode 100644 tests/virtio-scsi-test.c > > diff --git a/tests/Makefile b/tests/Makefile > index 308a5a2..75b4659 100644 > --- a/tests/Makefile > +++ b/tests/Makefile > @@ -78,6 +78,8 @@ check-qtest-virtio-y +=3D tests/virtio-blk-test$(EXES= UF) > gcov-files-virtio-y +=3D i386-softmmu/hw/block/virtio-blk.c > check-qtest-virtio-y +=3D tests/virtio-rng-test$(EXESUF) > gcov-files-virtio-y +=3D hw/virtio/virtio-rng.c > +check-qtest-virtio-y +=3D tests/virtio-scsi-test$(EXESUF) > +gcov-files-virtio-y +=3D i386-softmmu/hw/scsi/virtio-scsi.c > > check-qtest-pci-y +=3D tests/e1000-test$(EXESUF) > gcov-files-pci-y +=3D hw/net/e1000.c > @@ -249,6 +251,7 @@ tests/virtio-balloon-test$(EXESUF): tests/virtio-ba= lloon-test.o > tests/virtio-blk-test$(EXESUF): tests/virtio-blk-test.o > tests/virtio-net-test$(EXESUF): tests/virtio-net-test.o > tests/virtio-rng-test$(EXESUF): tests/virtio-rng-test.o > +tests/virtio-scsi-test$(EXESUF): tests/virtio-scsi-test.o > tests/tpci200-test$(EXESUF): tests/tpci200-test.o > tests/ipoctal232-test$(EXESUF): tests/ipoctal232-test.o > tests/qom-test$(EXESUF): tests/qom-test.o > diff --git a/tests/virtio-scsi-test.c b/tests/virtio-scsi-test.c > new file mode 100644 > index 0000000..3230908 > --- /dev/null > +++ b/tests/virtio-scsi-test.c > @@ -0,0 +1,35 @@ > +/* > + * QTest testcase for VirtIO SCSI > + * > + * Copyright (c) 2014 SUSE LINUX Products GmbH > + * > + * This work is licensed under the terms of the GNU GPL, version 2 or = later. > + * See the COPYING file in the top-level directory. > + */ > + > +#include > +#include > +#include "libqtest.h" > +#include "qemu/osdep.h" > + > +/* Tests only initialization so far. TODO: Replace with functional tes= ts */ > +static void pci_nop(void) > +{ > +} > + > +int main(int argc, char **argv) > +{ > + int ret; > + > + g_test_init(&argc, &argv, NULL); > + qtest_add_func("/virtio/scsi/pci/nop", pci_nop); > + > + qtest_start("-drive id=3Ddrv0,if=3Dnone,file=3D/dev/null " > + "-device virtio-scsi-pci,id=3Dvscsi0 " > + "-device scsi-hd,bus=3Dvscsi0.0,drive=3Ddrv0"); > + ret =3D g_test_run(); > + > + qtest_end(); > + > + return ret; > +} > ACK If we get a summer of code student, we could aim at making these tests=20 work on all PCI platforms. Paolo