From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:34670)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1WNqZ9-00042N-TW
	for qemu-devel@nongnu.org; Wed, 12 Mar 2014 17:20:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1WNqZ3-00038T-Ub
	for qemu-devel@nongnu.org; Wed, 12 Mar 2014 17:19:55 -0400
Received: from mx1.redhat.com ([209.132.183.28]:60829)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lersek@redhat.com>) id 1WNqZ3-00038O-N2
	for qemu-devel@nongnu.org; Wed, 12 Mar 2014 17:19:49 -0400
Message-ID: <5320CF72.70705@redhat.com>
Date: Wed, 12 Mar 2014 22:19:46 +0100
From: Laszlo Ersek <lersek@redhat.com>
MIME-Version: 1.0
References: <1394648890-933-1-git-send-email-ehabkost@redhat.com>
	<1394648890-933-4-git-send-email-ehabkost@redhat.com>
In-Reply-To: <1394648890-933-4-git-send-email-ehabkost@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH v2 3/4] acpi: Assert sts array limit on
	AcpiCpuHotplug_add()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Eduardo Habkost <ehabkost@redhat.com>, qemu-devel@nongnu.org
Cc: Igor Mammedov <imammedo@redhat.com>, =?ISO-8859-1?Q?Andreas_F=E4rber?= <afaerber@suse.de>, "Michael S. Tsirkin" <mst@redhat.com>

On 03/12/14 19:28, Eduardo Habkost wrote:
> AcpiCpuHotplug_add() can't handle vCPU arch IDs larger than
> ACPI_CPU_HOTPLUG_ID_LIMIT. Instead of corrupting memory in case the vCPU
> ID is too large, use g_assert() to ensure we are not over the limit.
> 
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
>  hw/acpi/cpu_hotplug.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/hw/acpi/cpu_hotplug.c b/hw/acpi/cpu_hotplug.c
> index 48928dc..2ad83a0 100644
> --- a/hw/acpi/cpu_hotplug.c
> +++ b/hw/acpi/cpu_hotplug.c
> @@ -43,6 +43,7 @@ void AcpiCpuHotplug_add(ACPIGPE *gpe, AcpiCpuHotplug *g, CPUState *cpu)
>  
>      *gpe->sts = *gpe->sts | ACPI_CPU_HOTPLUG_STATUS;
>      cpu_id = k->get_arch_id(CPU(cpu));
> +    g_assert((cpu_id / 8) < ACPI_GPE_PROC_LEN);
>      g->sts[cpu_id / 8] |= (1 << (cpu_id % 8));
>  }
>  
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>