From: Richard Henderson <rth@twiddle.net>
To: "Michael S. Tsirkin" <mst@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org
Subject: Re: [Qemu-devel] [PATCH 1/2] bswap.h: export bswap_le
Date: Wed, 12 Mar 2014 15:21:49 -0700 [thread overview]
Message-ID: <5320DDFD.1090405@twiddle.net> (raw)
In-Reply-To: <1394480575-3698-1-git-send-email-mst@redhat.com>
On 03/10/2014 12:43 PM, Michael S. Tsirkin wrote:
> it's a handy API for cases where we want to
> get size in bits as a parameter.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> include/qemu/bswap.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h
> index 0cb7c05..4489ad9 100644
> --- a/include/qemu/bswap.h
> +++ b/include/qemu/bswap.h
> @@ -423,9 +423,4 @@ static inline unsigned long leul_to_cpu(unsigned long v)
> #endif
> }
>
> -#undef le_bswap
> -#undef be_bswap
> -#undef le_bswaps
> -#undef be_bswaps
I don't like this because the bits "as parameter" must be constant
in order for token pasting to work. Better to just use the existing
function calls.
r~
prev parent reply other threads:[~2014-03-12 22:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 19:43 [Qemu-devel] [PATCH 1/2] bswap.h: export bswap_le Michael S. Tsirkin
2014-03-10 19:43 ` [Qemu-devel] [PATCH 2/2] acpi-build: don't access unaligned addresses Michael S. Tsirkin
2014-03-12 22:24 ` Richard Henderson
2014-03-12 22:25 ` [Qemu-devel] [PATCH] hw/i386: Use unaligned store functions building acpi tables Richard Henderson
2014-03-12 23:26 ` Peter Maydell
2014-03-13 13:30 ` Richard Henderson
2014-03-12 22:21 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5320DDFD.1090405@twiddle.net \
--to=rth@twiddle.net \
--cc=mst@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).