From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:47282) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNrXG-0003GS-3u for qemu-devel@nongnu.org; Wed, 12 Mar 2014 18:22:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNrX7-0006Gl-NC for qemu-devel@nongnu.org; Wed, 12 Mar 2014 18:22:02 -0400 Received: from mail-qg0-x22b.google.com ([2607:f8b0:400d:c04::22b]:46455) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNrX7-0006Ge-HQ for qemu-devel@nongnu.org; Wed, 12 Mar 2014 18:21:53 -0400 Received: by mail-qg0-f43.google.com with SMTP id f51so513541qge.2 for ; Wed, 12 Mar 2014 15:21:53 -0700 (PDT) Sender: Richard Henderson Message-ID: <5320DDFD.1090405@twiddle.net> Date: Wed, 12 Mar 2014 15:21:49 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1394480575-3698-1-git-send-email-mst@redhat.com> In-Reply-To: <1394480575-3698-1-git-send-email-mst@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 1/2] bswap.h: export bswap_le List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" , qemu-devel@nongnu.org Cc: peter.maydell@linaro.org On 03/10/2014 12:43 PM, Michael S. Tsirkin wrote: > it's a handy API for cases where we want to > get size in bits as a parameter. > > Signed-off-by: Michael S. Tsirkin > --- > include/qemu/bswap.h | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/include/qemu/bswap.h b/include/qemu/bswap.h > index 0cb7c05..4489ad9 100644 > --- a/include/qemu/bswap.h > +++ b/include/qemu/bswap.h > @@ -423,9 +423,4 @@ static inline unsigned long leul_to_cpu(unsigned long v) > #endif > } > > -#undef le_bswap > -#undef be_bswap > -#undef le_bswaps > -#undef be_bswaps I don't like this because the bits "as parameter" must be constant in order for token pasting to work. Better to just use the existing function calls. r~