From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51420) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNrpO-0000fh-65 for qemu-devel@nongnu.org; Wed, 12 Mar 2014 18:40:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNrpI-0004Mv-Pa for qemu-devel@nongnu.org; Wed, 12 Mar 2014 18:40:46 -0400 Sender: Richard Henderson Message-ID: <5320E264.7030608@twiddle.net> Date: Wed, 12 Mar 2014 15:40:36 -0700 From: Richard Henderson MIME-Version: 1.0 References: <1394478302-8474-1-git-send-email-tommusta@gmail.com> In-Reply-To: <1394478302-8474-1-git-send-email-tommusta@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/6] Refactor AES Instructions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Tom Musta , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org On 03/10/2014 12:04 PM, Tom Musta wrote: > This patch series addresses concerns raised by Richard Henderson regarding redundant > copies of Advanced Encryption Standard (AES) data and code (see > http://lists.nongnu.org/archive/html/qemu-devel/2014-02/msg04391.html). > > The patches declare commonly used AES tables in the include/qemu/aes.h header file > and define the tables in util/aes.c, thus eliminating redundant copies. > > Minor refactorization of the i386 and ARM instruction models are made to utilize > this common support. The newly added PowerPC instructions are completely > rewritten and look much more like the i386 equivalents; a substantial amount of > code is eliminated. > > Tom Musta (6): > util: Add S-Box and InvS-Box Arrays to Common AES Utils > util: Add AES ShiftRows and InvShiftRows Tables > util: Add InvMixColumns > target-i386: Use Common ShiftRows and InvShiftRows Tables > target-arm: Use Common Tables in AES Instructions > target-ppc: Refactor AES Instructions Other than the one nit, Reviewed-by: Richard Henderson r~