From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNs8i-000881-S3 for qemu-devel@nongnu.org; Wed, 12 Mar 2014 19:00:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNs8d-0002D5-EG for qemu-devel@nongnu.org; Wed, 12 Mar 2014 19:00:44 -0400 Received: from mail-pd0-f179.google.com ([209.85.192.179]:62223) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNs8d-0002Cw-8y for qemu-devel@nongnu.org; Wed, 12 Mar 2014 19:00:39 -0400 Received: by mail-pd0-f179.google.com with SMTP id w10so195792pde.10 for ; Wed, 12 Mar 2014 16:00:38 -0700 (PDT) Message-ID: <5320E710.4060009@ozlabs.ru> Date: Thu, 13 Mar 2014 10:00:32 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1392253715-5416-1-git-send-email-aik@ozlabs.ru> <53157AC7.7070303@ozlabs.ru> <5320726E.3090308@suse.de> In-Reply-To: <5320726E.3090308@suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [Qemu-devel] [PATCH] xics-kvm: fix reset function List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Paul Mackerras , Alexander Graf On 03/13/2014 01:42 AM, Andreas Färber wrote: > Am 04.03.2014 08:03, schrieb Alexey Kardashevskiy: >> On 02/13/2014 12:08 PM, Alexey Kardashevskiy wrote: >>> Currently interrupt priorities are set to 0 (highest) at the very >>> beginning of the guest execution which is not correct and makes the guest >>> produce random interrupt error messages such as: >>> "Interrupt 0x1001 (real) is invalid, disabling it". >>> This also prevents interrupt states from correct migration. >>> >>> This initializes priority to 0xFF as the emulated XICS does. >> >> >> Ping? Pretty simple patch suggested by Paul Mackerras. > > Is this one still needed? Can we document a Suggested-by? Yes. Suggested-by: Paul Mackerras > Andreas > >> >> >> >>> Signed-off-by: Alexey Kardashevskiy >>> --- >>> hw/intc/xics_kvm.c | 9 +++++++++ >>> 1 file changed, 9 insertions(+) >>> >>> diff --git a/hw/intc/xics_kvm.c b/hw/intc/xics_kvm.c >>> index c203646..eaf94d9 100644 >>> --- a/hw/intc/xics_kvm.c >>> +++ b/hw/intc/xics_kvm.c >>> @@ -269,6 +269,15 @@ static void ics_kvm_set_irq(void *opaque, int srcno, int val) >>> >>> static void ics_kvm_reset(DeviceState *dev) >>> { >>> + ICSState *ics = ICS(dev); >>> + int i; >>> + >>> + memset(ics->irqs, 0, sizeof(ICSIRQState) * ics->nr_irqs); >>> + for (i = 0; i < ics->nr_irqs; i++) { >>> + ics->irqs[i].priority = 0xff; >>> + ics->irqs[i].saved_priority = 0xff; >>> + } >>> + >>> ics_set_kvm_state(ICS(dev), 1); >>> } >>> >>> >> >> > > -- Alexey