From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46471) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNtWZ-0005cn-Qt for qemu-devel@nongnu.org; Wed, 12 Mar 2014 20:29:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNtWT-0007yk-Qn for qemu-devel@nongnu.org; Wed, 12 Mar 2014 20:29:27 -0400 Received: from mx1.redhat.com ([209.132.183.28]:27764) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNtWT-0007yY-I0 for qemu-devel@nongnu.org; Wed, 12 Mar 2014 20:29:21 -0400 Message-ID: <5320FBDD.7050401@redhat.com> Date: Thu, 13 Mar 2014 01:29:17 +0100 From: Laszlo Ersek MIME-Version: 1.0 References: <1394648890-933-1-git-send-email-ehabkost@redhat.com> <1394648890-933-2-git-send-email-ehabkost@redhat.com> <5320CF03.6050309@redhat.com> <5320CF40.2040606@redhat.com> <20140313001207.GE2285@otherpad.lan.raisama.net> In-Reply-To: <20140313001207.GE2285@otherpad.lan.raisama.net> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1/4] acpi: Add ACPI_CPU_HOTPLUG_ID_LIMIT macro List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Habkost Cc: Igor Mammedov , "Michael S. Tsirkin" , qemu-devel@nongnu.org, =?ISO-8859-1?Q?Andreas_F=E4rber?= On 03/13/14 01:12, Eduardo Habkost wrote: > On Wed, Mar 12, 2014 at 10:18:56PM +0100, Laszlo Ersek wrote: >> On 03/12/14 22:17, Laszlo Ersek wrote: >>> On 03/12/14 19:28, Eduardo Habkost wrote: >>>> The new macro will be helpful to allow us to detect too large SMP limits >>>> before it is too late. >>>> >>>> Signed-off-by: Eduardo Habkost >>>> --- >>>> include/hw/acpi/cpu_hotplug_defs.h | 8 ++++++++ >>>> 1 file changed, 8 insertions(+) >>>> >>>> diff --git a/include/hw/acpi/cpu_hotplug_defs.h b/include/hw/acpi/cpu_hotplug_defs.h >>>> index 2725b50..9f33663 100644 >>>> --- a/include/hw/acpi/cpu_hotplug_defs.h >>>> +++ b/include/hw/acpi/cpu_hotplug_defs.h >>>> @@ -17,7 +17,15 @@ >>>> * between C and ASL code. >>>> */ >>>> #define ACPI_CPU_HOTPLUG_STATUS 4 >>>> + >>>> +/* Limit for CPU arch IDs for CPU hotplug. All hotpluggable CPUs should >>>> + * have CPUClass.get_arch_id() < ACPI_CPU_HOTPLUG_ID_LIMIT. >>>> + */ >>>> +#define ACPI_CPU_HOTPLUG_ID_LIMIT 256 >>>> + >>>> +/* 256 CPU IDs, 8 bits per entry: */ >>>> #define ACPI_GPE_PROC_LEN 32 >>>> + >>>> #define ICH9_CPU_HOTPLUG_IO_BASE 0x0CD8 >>>> #define PIIX4_CPU_HOTPLUG_IO_BASE 0xaf00 >>>> >>>> >>> >>> You could actually derive ACPI_GPE_PROC_LEN from >>> ACPI_CPU_HOTPLUG_ID_LIMIT, by dividing with CHAR_BIT. >> >> >> (Or vice versa -- get the limit from PROC_LEN by multiplication.) > > I tried it, but the ASL compiler doesn't seem to be able to evaluate the > expression. Ah right, I did see Igor's comment in the file! OK then. Thanks, Laszlo