From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49965) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNwOF-00005r-VP for qemu-devel@nongnu.org; Wed, 12 Mar 2014 23:33:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WNwO6-0007bL-UJ for qemu-devel@nongnu.org; Wed, 12 Mar 2014 23:33:03 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:34253) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WNwO6-0007ab-Ok for qemu-devel@nongnu.org; Wed, 12 Mar 2014 23:32:54 -0400 Received: by mail-pa0-f51.google.com with SMTP id kq14so471407pab.38 for ; Wed, 12 Mar 2014 20:32:52 -0700 (PDT) Message-ID: <532126DE.8050608@ozlabs.ru> Date: Thu, 13 Mar 2014 14:32:46 +1100 From: Alexey Kardashevskiy MIME-Version: 1.0 References: <1392904246-15575-1-git-send-email-aik@ozlabs.ru> <1392904246-15575-2-git-send-email-aik@ozlabs.ru> <5306094B.4010608@redhat.com> <53060B40.9010903@ozlabs.ru> <53060BB8.5010302@redhat.com> In-Reply-To: <53060BB8.5010302@redhat.com> Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v5 1/6] boot: extend get_boot_devices_list() to ignore suffixes List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , qemu-devel@nongnu.org Cc: qemu-ppc@nongnu.org, Alexander Graf , Andreas Faerber On 02/21/2014 01:05 AM, Paolo Bonzini wrote: > Il 20/02/2014 15:03, Alexey Kardashevskiy ha scritto: >> On 02/21/2014 12:55 AM, Paolo Bonzini wrote: >>> Il 20/02/2014 14:50, Alexey Kardashevskiy ha scritto: >>>> As suffixes do not make sense for sPAPR's device tree and >>>> there is no way to filter them out on the BusState::get_fw_dev_path >>>> level, let's add an ability for the external caller to specify >>>> whether to apply suffixes or not. >>>> >>>> We could handle suffixes in SLOF (ignore for now) but this would require >>>> serious rework in the node opening code in SLOF which has no obvious >>>> benefit for the currently emulated sPAPR machine. >>> >>> For the record, the commit message is not entirely correct in presenting >>> the situation. QEMU *does not care in any way* of benefits for the >>> currently emulated sPAPR machine. The benefit would be to QEMU in having >>> simpler code. >>> >>> You just got a wildcard because Forth is scary. :) >> >> I know :) Should I remove that part and replace it with the "scary" one? > > No, unless you have to respin for other reasons (I hope not). I am about to respin the series against the latest QOM stuff and I am about to change commit message in the "The benefit would be to QEMU in having simpler code" part - what part of QEMU gets simpler? I am avoiding fixing SLOF and I am fixing QEMU so QEMU gets (liiiiittle) bit more complicated but not simpler :) What do I miss? -- Alexey