From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48491)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WO36g-0004FS-An
	for qemu-devel@nongnu.org; Thu, 13 Mar 2014 06:43:30 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WO36W-00013h-PW
	for qemu-devel@nongnu.org; Thu, 13 Mar 2014 06:43:22 -0400
Received: from mail-ee0-x22d.google.com ([2a00:1450:4013:c00::22d]:56827)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <paolo.bonzini@gmail.com>) id 1WO36W-00013V-IC
	for qemu-devel@nongnu.org; Thu, 13 Mar 2014 06:43:12 -0400
Received: by mail-ee0-f45.google.com with SMTP id d17so328158eek.32
	for <qemu-devel@nongnu.org>; Thu, 13 Mar 2014 03:43:11 -0700 (PDT)
Sender: Paolo Bonzini <paolo.bonzini@gmail.com>
Message-ID: <53218BBC.8030108@redhat.com>
Date: Thu, 13 Mar 2014 11:43:08 +0100
From: Paolo Bonzini <pbonzini@redhat.com>
MIME-Version: 1.0
References: <1394643643-27122-1-git-send-email-armbru@redhat.com>
In-Reply-To: <1394643643-27122-1-git-send-email-armbru@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] blockdev: Refuse to open encrypted image
	unless paused
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: kwolf@redhat.com, stefanha@redhat.com

Il 12/03/2014 18:00, Markus Armbruster ha scritto:
> +    } else if (!runstate_check(RUN_STATE_PRELAUNCH)
> +            && !runstate_check(RUN_STATE_PAUSED)) { /* HACK */

Why not "if (runstate_is_running())"?

Paolo

> +        error_setg(errp,
> +                   "Guest must be stopped for opening of encrypted image");
> +        ret = -EBUSY;
> +        goto close_and_fail;