From: "Andreas Färber" <afaerber@suse.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Peter Crosthwaite <peter.crosthwaite@xilinx.com>,
Anthony Liguori <anthony@codemonkey.ws>,
"Michael S. Tsirkin" <mst@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Alexander Graf <agraf@suse.de>,
QEMU Developers <qemu-devel@nongnu.org>,
Bandan Das <bsd@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PULL for-2.0-rc0 v2 00/31] QOM devices patch queue 2014-03-12
Date: Thu, 13 Mar 2014 13:33:48 +0100 [thread overview]
Message-ID: <5321A5AC.8050103@suse.de> (raw)
In-Reply-To: <CAFEAcA_Li6PBeVYd1U3MaGEiaRv8K6ce1NNypcH8iO6TO_krHQ@mail.gmail.com>
Am 13.03.2014 12:22, schrieb Peter Maydell:
> On 13 March 2014 00:27, Andreas Färber <afaerber@suse.de> wrote:
>> Hello Peter,
>>
>> This is my QOM (devices) patch queue. Please pull.
>>
>> v2 changes qom-test.
>
> No, this is still broken:
> /home/petmay01/linaro/qemu-for-merges/tests/qom-test.c: In function ‘qmp’:
> /home/petmay01/linaro/qemu-for-merges/tests/libqtest.h:359:60: sorry,
> unimplemented: function ‘qmp’ can never be inlined because it uses
> variable argument lists
> make: *** [tests/qom-test.o] Error 1
> make: Leaving directory `/home/petmay01/linaro/qemu-for-merges/build/all'
>
> Moving qmp() into libqtest.c and just having a
> prototype in libqtest.h (ie having it not be an
> inline varargs function) seems to fix this.
>
> I don't know why (a) it didn't complain about
> earlier uses of qmp() or (b) why it's not complaining
> about qmp_discard_response() now [perhaps the compiler
> manages to special case "varargs but the varargs list
> is empty]. Probably safest to move qmp_discard_response
> too, though.
My v1 did have empty varargs, so that's not it...
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2014-03-13 12:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 0:27 [Qemu-devel] [PULL for-2.0-rc0 v2 00/31] QOM devices patch queue 2014-03-12 Andreas Färber
2014-03-13 11:22 ` Peter Maydell
2014-03-13 12:33 ` Andreas Färber [this message]
2014-03-13 13:21 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5321A5AC.8050103@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=anthony@codemonkey.ws \
--cc=armbru@redhat.com \
--cc=bsd@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.crosthwaite@xilinx.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).