From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50255)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1WO5TT-0005aF-Ay
	for qemu-devel@nongnu.org; Thu, 13 Mar 2014 09:15:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tommusta@gmail.com>) id 1WO5TO-0002yi-BW
	for qemu-devel@nongnu.org; Thu, 13 Mar 2014 09:15:03 -0400
Message-ID: <5321AF4E.8040909@gmail.com>
Date: Thu, 13 Mar 2014 08:14:54 -0500
From: Tom Musta <tommusta@gmail.com>
MIME-Version: 1.0
References: <1394478302-8474-1-git-send-email-tommusta@gmail.com>
	<5320E264.7030608@twiddle.net>
In-Reply-To: <5320E264.7030608@twiddle.net>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 0/6] Refactor AES Instructions
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Richard Henderson <rth@twiddle.net>, qemu-devel@nongnu.org
Cc: qemu-ppc@nongnu.org

On 3/12/2014 5:40 PM, Richard Henderson wrote:
> On 03/10/2014 12:04 PM, Tom Musta wrote:
>> This patch series addresses concerns raised by Richard Henderson regarding redundant
>> copies of Advanced Encryption Standard (AES) data and code (see
>> http://lists.nongnu.org/archive/html/qemu-devel/2014-02/msg04391.html).
>>
>> The patches declare commonly used AES tables in the include/qemu/aes.h header file
>> and define the tables in util/aes.c, thus eliminating redundant copies.
>>
>> Minor refactorization of the i386 and ARM instruction models are made to utilize
>> this common support.  The newly added PowerPC instructions are completely 
>> rewritten and look much more like the i386 equivalents; a substantial amount of
>> code is eliminated.
>>
>> Tom Musta (6):
>>   util: Add S-Box and InvS-Box Arrays to Common AES Utils
>>   util: Add AES ShiftRows and InvShiftRows Tables
>>   util: Add InvMixColumns
>>   target-i386: Use Common ShiftRows and InvShiftRows Tables
>>   target-arm: Use Common Tables in AES Instructions
>>   target-ppc: Refactor AES Instructions
> 
> Other than the one nit,
> 
> Reviewed-by: Richard Henderson <rth@twiddle.net>
> 
> 
> r~
> 
Thanks.  I will rework the nit and republish a V2.