From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53016) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WO5fN-0002En-5C for qemu-devel@nongnu.org; Thu, 13 Mar 2014 09:27:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WO5fI-00071P-4M for qemu-devel@nongnu.org; Thu, 13 Mar 2014 09:27:20 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39654) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WO5fH-00071L-RS for qemu-devel@nongnu.org; Thu, 13 Mar 2014 09:27:16 -0400 Received: from int-mx12.intmail.prod.int.phx2.redhat.com (int-mx12.intmail.prod.int.phx2.redhat.com [10.5.11.25]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s2DDRFMS006057 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 13 Mar 2014 09:27:15 -0400 Message-ID: <5321B232.6090603@redhat.com> Date: Thu, 13 Mar 2014 07:27:14 -0600 From: Eric Blake MIME-Version: 1.0 References: <1394643643-27122-1-git-send-email-armbru@redhat.com> <53218BBC.8030108@redhat.com> In-Reply-To: <53218BBC.8030108@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CCDUwXsptbM0127dOWIFFH8X3peXA0HXe" Subject: Re: [Qemu-devel] [PATCH] blockdev: Refuse to open encrypted image unless paused List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini , Markus Armbruster , qemu-devel@nongnu.org Cc: kwolf@redhat.com, stefanha@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --CCDUwXsptbM0127dOWIFFH8X3peXA0HXe Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 03/13/2014 04:43 AM, Paolo Bonzini wrote: > Il 12/03/2014 18:00, Markus Armbruster ha scritto: >> + } else if (!runstate_check(RUN_STATE_PRELAUNCH) >> + && !runstate_check(RUN_STATE_PAUSED)) { /* HACK */ >=20 > Why not "if (runstate_is_running())"? Because that lacks PRELAUNCH, but PRELAUNCH also needs the protection. --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --CCDUwXsptbM0127dOWIFFH8X3peXA0HXe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJTIbIyAAoJEKeha0olJ0NqZCcH/RAKV5WnMXnX84DoM/Cyuxy9 h/v7XWus8z9QoH64DlY/VTXpfjoYd5Sj2ByTFFzonCfSu9MOJcnIiojltejP5tsx uSVUvteCEa9VjdYuWUsPVX3vnJHud7U7qdAXfYZn9JP1F/yKJJQDvBDPeejlTAyT Qqq/5VC5Eaj4m26PbiVbj+UVR6erRqLg/mlFm9AffRBD37N/lsmLk4it90jcCt9l QM5pDI1aW0g4Iq6qekT0cqru97SGrBvkqZu+g9z59bWqFwOUi9NGmfztC6VrwHLp F7brsZnuune3+fbS0dmw+1da006/OLL3mtzTOZExMkB4t4MJUTaKaACGOpCX24Q= =cqT4 -----END PGP SIGNATURE----- --CCDUwXsptbM0127dOWIFFH8X3peXA0HXe--